[webkit-changes] [WebKit/WebKit] d62fea: Fix find-in-page for words spanning display:contents

Commit Queue noreply at github.com
Sat May 4 08:36:30 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d62fea57b1cc71a3c91be926c749759ac3d1d446
      https://github.com/WebKit/WebKit/commit/d62fea57b1cc71a3c91be926c749759ac3d1d446
  Author: Ahmad Saleem <ahmad.saleem792 at gmail.com>
  Date:   2024-05-04 (Sat, 04 May 2024)

  Changed paths:
    M LayoutTests/accessibility/display-contents/aria-grid-expected.txt
    M LayoutTests/accessibility/display-contents/list-expected.txt
    M LayoutTests/accessibility/display-contents/role-row-headers-expected.txt
    M LayoutTests/accessibility/display-contents/table-expected.txt
    M LayoutTests/accessibility/display-contents/tree-and-treeitems-expected.txt
    M LayoutTests/accessibility/live-region-attributes-update-after-dynamic-change-expected.txt
    M LayoutTests/accessibility/mac/aria-drag-drop-expected.txt
    M LayoutTests/dom/html/document-renderobject-null-crash-expected.txt
    M LayoutTests/fast/css/counters/findPlaceForCounter-display-content-sibling-crash-expected.txt
    M LayoutTests/fast/events/ios/click-event-and-display-contents-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-display/accessibility/display-contents-role-and-label-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/the-innertext-and-outertext-properties/getter-expected.txt
    M LayoutTests/platform/glib/accessibility/display-contents/aria-grid-expected.txt
    M LayoutTests/platform/glib/accessibility/display-contents/table-expected.txt
    M LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-display/accessibility/display-contents-role-and-label-expected.txt
    M LayoutTests/platform/ios/accessibility/display-contents/table-expected.txt
    M Source/WebCore/editing/TextIterator.cpp

  Log Message:
  -----------
  Fix find-in-page for words spanning display:contents

https://bugs.webkit.org/show_bug.cgi?id=273686

Reviewed by Simon Fraser.

This aligns WebKit with Gecko / Firefox and Blink / Chromium.

Merge; https://source.chromium.org/chromium/chromium/src/+/2698ab2e0135bd4b62a4e472eceb3174592bf605

This patch is to ensure that 'TextIerator' does not emit lines before/after
display:contents elements.

* Source/WebCore/editing/TextIterator.cpp:
(shouldEmitNewlinesBeforeAndAfterNode):
* LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/the-innertext-and-outertext-properties/getter-expected.txt: Rebaselined
* LayoutTests/accessibility/display-contents/aria-grid-expected.txt: Ditto
* LayoutTests/accessibility/display-contents/list-expected.txt: Ditto
* LayoutTests/accessibility/display-contents/role-row-headers-expected.txt: Ditto
* LayoutTests/accessibility/display-contents/table-expected.txt: Ditto
* LayoutTests/accessibility/display-contents/tree-and-treeitems-expected.txt: Ditto
* LayoutTests/accessibility/live-region-attributes-update-after-dynamic-change-expected.txt: Ditto
* LayoutTests/accessibility/mac/aria-drag-drop-expected.txt: Ditto
* LayoutTests/dom/html/document-renderobject-null-crash-expected.txt: Ditto
* LayoutTests/fast/css/counters/findPlaceForCounter-display-content-sibling-crash-expected.txt: Ditto
* LayoutTests/fast/events/ios/click-event-and-display-contents-expected.txt: Ditto
* LayoutTests/imported/w3c/web-platform-tests/css/css-display/accessibility/display-contents-role-and-label-expected.txt: Ditto
* LayoutTests/platform/glib/accessibility/display-contents/aria-grid-expected.txt: Ditto
* LayoutTests/platform/glib/accessibility/display-contents/table-expected.txt: Ditto
* LayoutTests/platform/ios/accessibility/display-contents/table-expected.txt: Ditto
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-display/accessibility/display-contents-role-and-label-expected.txt: Ditto

Canonical link: https://commits.webkit.org/278377@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list