[webkit-changes] [WebKit/WebKit] b675dc: AX: Map AccessibilityRole::TabList to UIAccessibil...

Tyler Wilcock noreply at github.com
Sat May 4 07:44:03 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b675dc6863ca418dafb534d00cc5b39c505210b9
      https://github.com/WebKit/WebKit/commit/b675dc6863ca418dafb534d00cc5b39c505210b9
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2024-05-04 (Sat, 04 May 2024)

  Changed paths:
    A LayoutTests/accessibility/ios-simulator/menu-item-trait-expected.txt
    A LayoutTests/accessibility/ios-simulator/menu-item-trait.html
    A LayoutTests/accessibility/ios-simulator/tab-bar-trait-expected.txt
    A LayoutTests/accessibility/ios-simulator/tab-bar-trait.html
    M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
    M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp
    M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h
    M Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl
    M Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm

  Log Message:
  -----------
  AX: Map AccessibilityRole::TabList to UIAccessibilityTabBarTrait equivalent, remove usage of _axTabButtonTrait
https://bugs.webkit.org/show_bug.cgi?id=273707
rdar://problem/127510709

Reviewed by Chris Fleizach.

_axTabButtonTrait is a private trait, so we shouldn't use it. It's possible to achieve the same functionality by
mapping the role="tablist" container to UIAccessibilityTabBarTrait (a public trait), so this patch does that.

* LayoutTests/accessibility/ios-simulator/menu-item-trait-expected.txt: Added.
* LayoutTests/accessibility/ios-simulator/menu-item-trait.html: Added.
* LayoutTests/accessibility/ios-simulator/tab-bar-trait-expected.txt: Added.
* LayoutTests/accessibility/ios-simulator/tab-bar-trait.html: Added.
* Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityTraits]):
* Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::hasTabBarTrait):
(WTR::AccessibilityUIElement::hasMenuItemTrait):
* Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
* Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
* Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::hasTabBarTrait):
(WTR::AccessibilityUIElement::hasMenuItemTrait):

Canonical link: https://commits.webkit.org/278376@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list