[webkit-changes] [WebKit/WebKit] c1c858: Duolingo continue/next bar trails off of viewport

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c1c858cf081e67326c44328c12ab5ddb53a8799b
      https://github.com/WebKit/WebKit/commit/c1c858cf081e67326c44328c12ab5ddb53a8799b
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-05-01 (Wed, 01 May 2024)

  Changed paths:
    A LayoutTests/fast/dynamic/out-of-flow-going-in-flow-inside-grid-expected.html
    A LayoutTests/fast/dynamic/out-of-flow-going-in-flow-inside-grid.html
    M Source/WebCore/rendering/RenderBox.cpp

  Log Message:
  -----------
  Duolingo continue/next bar trails off of viewport
https://bugs.webkit.org/show_bug.cgi?id=273526
<rdar://126777425>

Reviewed by Antti Koivisto.

When a box changes containing block through style mutation (e.g. by going from out-of-flow to inflow),
its (grid/flex driven) override value becomes stale.
(note that these override values are apparently sticky and we have to keep them around in-between layouts
for example to be able to resolve percent padding values for getComputedStyle)

* LayoutTests/fast/dynamic/out-of-flow-going-in-flow-inside-grid-expected.html: Added.
* LayoutTests/fast/dynamic/out-of-flow-going-in-flow-inside-grid.html: Added.
* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutPositionedObject):

Canonical link: https://commits.webkit.org/278209@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications