[webkit-changes] [WebKit/WebKit] 2a15af: Web Inspector: Top or bottom of Web Inspector is c...

Wed May 1 05:08:03 PDT 2024

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2a15afd431a01ae3aeb4a971e919a0669ace0399
      https://github.com/WebKit/WebKit/commit/2a15afd431a01ae3aeb4a971e919a0669ace0399
  Author: Razvan Caliman <rcaliman at apple.com>
  Date:   2024-05-01 (Wed, 01 May 2024)

  Changed paths:
    M Source/WebInspectorUI/UserInterface/Views/ConsoleDrawer.js
    M Source/WebInspectorUI/UserInterface/Views/QuickConsole.js
    M Source/WebInspectorUI/UserInterface/Views/Variables.css

  Log Message:
  -----------
  Web Inspector: Top or bottom of Web Inspector is cut off on short viewports
https://bugs.webkit.org/show_bug.cgi?id=273506
rdar://117272735

Reviewed by Devin Rousso.

The Console Drawer was allowed to be resized to an arbitrarily capped maximum height
of `<div id="main">` that did not take into account the minimum height defined
by the Tab Browser or the space taken up by the Quick Console.

Their common container is an absolutely-positioned flex container
that has its overflow hidden by `overflow: hidden` on the Web Inspector `<body>`.

So when the Console Drawer was oversized, it pushed either the Quick Console
or the top of the Tab bar beyond the visible viewport, depending on the successive
layout operations (CSS and programmatic) that occur during Web Inspector launch.

The patch sets a maximum height for the Console Drawer that is calculated explicitly.

* Source/WebInspectorUI/UserInterface/Views/ConsoleDrawer.js:
(WI.ConsoleDrawer.prototype._updateDrawerHeight):
* Source/WebInspectorUI/UserInterface/Views/QuickConsole.js:
* Source/WebInspectorUI/UserInterface/Views/Variables.css:
(:root):

Canonical link: https://commits.webkit.org/278208@main

To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications