[webkit-changes] [WebKit/WebKit] f382be: NULL pointer : crash under RenderLayerCompositor:...

[nishajain61]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f382be44f6ec4f9d5a719a183c70b2e9aaa41254
      https://github.com/WebKit/WebKit/commit/f382be44f6ec4f9d5a719a183c70b2e9aaa41254
  Author: Nisha Jain <nisha_jain at apple.com>
  Date:   2024-03-26 (Tue, 26 Mar 2024)

  Changed paths:
    A LayoutTests/fast/rendering/render-compositor-null-layer-crash-expected.txt
    A LayoutTests/fast/rendering/render-compositor-null-layer-crash.html
    M Source/WebCore/rendering/RenderLayerCompositor.cpp

  Log Message:
  -----------
  NULL pointer :  crash under RenderLayerCompositor::scrollableAreaForScrollingNodeID()
https://bugs.webkit.org/show_bug.cgi?id=265820
rdar://118424482.

Reviewed by Simon Fraser.

Null RenderLayer pointer in RenderLayerCompositor::scrollableAreaForScrollingNodeID().
As the RenderLayerCompositor has a HashMap which provides a WeakPtr to RenderLayer but the validity
of this object is not checked before using.

* LayoutTests/fast/rendering/render-compositor-null-layer-crash-expected.txt: Added test expected file.
* LayoutTests/fast/rendering/render-compositor-null-layer-crash.html: Added test case.
* Source/WebCore/rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::scrollableAreaForScrollingNodeID const): Checked validity of WeakPtr to RenderLayer before accessing it.

Originally-landed-as: 272448.252 at safari-7618-branch (a7977801dff3). rdar://124556059
Canonical link: https://commits.webkit.org/276701@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications