[webkit-changes] [WebKit/WebKit] 2932db: [IFC] Do not treat out-of-flow line break as text ...

Alan Baradlay noreply at github.com
Tue Mar 26 11:26:20 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2932db01f807bec257d8022434f43a6c02ad4221
      https://github.com/WebKit/WebKit/commit/2932db01f807bec257d8022434f43a6c02ad4221
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-03-26 (Tue, 26 Mar 2024)

  Changed paths:
    A LayoutTests/fast/text/out-of-flow-line-break-crash-expected.txt
    A LayoutTests/fast/text/out-of-flow-line-break-crash.html
    M Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/TextOnlySimpleLineBuilder.cpp

  Log Message:
  -----------
  [IFC] Do not treat out-of-flow line break as text content
https://bugs.webkit.org/show_bug.cgi?id=267268
rdar://120662940

Reviewed by Antti Koivisto.

Out-of-flow line break is not eligible for simplified (text-only) line building.

* LayoutTests/fast/text/out-of-flow-line-break-crash-expected.txt: Added.
* LayoutTests/fast/text/out-of-flow-line-break-crash.html: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:
(WebCore::Layout::isTextOrLineBreak):
* Source/WebCore/layout/formattingContexts/inline/TextOnlySimpleLineBuilder.cpp:
(WebCore::Layout::TextOnlySimpleLineBuilder::placeNonWrappingInlineTextContent):

Originally-landed-as: 272448.28 at safari-7618-branch (2658caa71663). rdar://124557079
Canonical link: https://commits.webkit.org/276700@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list