[webkit-changes] [WebKit/WebKit] 1674e8: [SVG2] Remove non-standard `animateColor`

Commit Queue noreply at github.com
Tue Mar 26 04:19:52 PDT 2024 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1674e8f0e5b811710ca6f0b03e4d708a53768958
      https://github.com/WebKit/WebKit/commit/1674e8f0e5b811710ca6f0b03e4d708a53768958
  Author: Ahmad Saleem <ahmad.saleem792 at gmail.com>
  Date:   2024-03-26 (Tue, 26 Mar 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/svg/import/animate-elem-23-t-manual.svg
    M LayoutTests/imported/w3c/web-platform-tests/svg/import/animate-elem-84-t-manual.svg
    M LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/import/animate-elem-30-t-manual-expected.txt
    M LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/import/animate-elem-85-t-manual-expected.txt
    M LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/import/animate-pservers-grad-01-b-manual-expected.txt
    M LayoutTests/platform/gtk/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt
    A LayoutTests/platform/gtk/svg/W3C-SVG-1.1/animate-elem-85-t-expected.txt
    M LayoutTests/platform/ios/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt
    M LayoutTests/platform/ios/svg/W3C-SVG-1.1/animate-elem-85-t-expected.txt
    M LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/import/animate-elem-30-t-manual-expected.txt
    M LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/import/animate-elem-85-t-manual-expected.txt
    M LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/import/animate-pservers-grad-01-b-manual-expected.txt
    M LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt
    M LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-85-t-expected.txt
    M LayoutTests/platform/wpe/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt
    M LayoutTests/platform/wpe/svg/W3C-SVG-1.1/animate-elem-85-t-expected.txt
    M LayoutTests/svg/W3C-SVG-1.1/animate-elem-23-t.svg
    M LayoutTests/svg/W3C-SVG-1.1/animate-elem-84-t.svg
    M LayoutTests/svg/W3C-SVG-1.1/animate-elem-85-t.svg
    M LayoutTests/svg/W3C-SVG-1.1/pservers-grad-19-b.svg
    M LayoutTests/svg/animations/animate-montion-invalid-attribute.svg
    M LayoutTests/svg/animations/animateColor-additive-2a-expected.svg
    M LayoutTests/svg/animations/animateColor-additive-2b-expected.svg
    M LayoutTests/svg/animations/animateColor-additive-2c-expected.svg
    M LayoutTests/svg/animations/animateColor-additive-2d-expected.svg
    M LayoutTests/svg/animations/resources/additive-type-by-animation.svg
    M LayoutTests/svg/custom/animation-currentColor.svg
    M LayoutTests/svg/custom/global-constructors-expected.txt
    M LayoutTests/svg/custom/global-constructors.html
    M LayoutTests/svg/dom/svg2-inheritance-expected.txt
    M LayoutTests/svg/dom/svg2-inheritance.html
    M Source/WebCore/CMakeLists.txt
    M Source/WebCore/DerivedSources-input.xcfilelist
    M Source/WebCore/DerivedSources-output.xcfilelist
    M Source/WebCore/DerivedSources.make
    M Source/WebCore/Sources.txt
    R Source/WebCore/svg/SVGAnimateColorElement.cpp
    R Source/WebCore/svg/SVGAnimateColorElement.h
    R Source/WebCore/svg/SVGAnimateColorElement.idl
    M Source/WebCore/svg/SVGAnimateElementBase.cpp
    M Source/WebCore/svg/SVGAnimateElementBase.h
    M Source/WebCore/svg/SVGAnimationElement.cpp
    M Source/WebCore/svg/svgtags.in

  Log Message:
  -----------
  [SVG2] Remove non-standard `animateColor`

https://bugs.webkit.org/show_bug.cgi?id=191370
rdar://problem/122586568

Reviewed by Tim Nguyen and Anne van Kesteren.

This patch is to align WebKit with Gecko / Firefox, Blink / Chromium
and Web Specification [1]:

[1] https://svgwg.org/specs/animations/#ChangesSinceSVG11

"Removed the animateColor element."

It was removed by Blink in 2014 while Firefox never supported this,
since all use cases can be tackled with `animate`.

> Compiler & Build System Changes:
* Source/WebCore/CMakeLists.txt:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources-output.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Sources.txt:

> Deleted Files:
* Source/WebCore/svg/SVGAnimateColorElement.cpp:
* Source/WebCore/svg/SVGAnimateColorElement.h:
* Source/WebCore/svg/SVGAnimateColorElement.idl:

> Modified:
* Source/WebCore/svg/SVGAnimateElementBase.cpp:
(SVGAnimateElementBase::SVGAnimateElementBase):
* Source/WebCore/svg/SVGAnimateElementBase.h:
(isType):
* Source/WebCore/svg/SVGAnimationElement.cpp:
(SVGAnimationElement::currentValuesForValuesAnimation):
* Source/WebCore/svg/svgtags.in: Retain `parsing rules`

> Tests & Test Expectations Update:
* LayoutTests/imported/w3c/web-platform-tests/svg/import/animate-elem-23-t-manual.svg:
* LayoutTests/imported/w3c/web-platform-tests/svg/import/animate-elem-84-t-manual.svg:
* LayoutTests/svg/animations/animateColor-additive-2a-expected.svg:
* LayoutTests/svg/animations/animateColor-additive-2b-expected.svg:
* LayoutTests/svg/animations/animateColor-additive-2c-expected.svg:
* LayoutTests/svg/animations/animateColor-additive-2d-expected.svg:
* LayoutTests/svg/animations/resources/additive-type-by-animation.svg:
* LayoutTests/svg/custom/animation-currentColor.svg:
* LayoutTests/svg/W3C-SVG-1.1/animate-elem-23-t.svg:
* LayoutTests/svg/W3C-SVG-1.1/animate-elem-84-t.svg:
* LayoutTests/svg/W3C-SVG-1.1/animate-elem-85-t.svg:
* LayoutTests/svg/W3C-SVG-1.1/pservers-grad-19-b.svg:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/import/animate-elem-30-t-manual-expected.txt:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/import/animate-elem-85-t-manual-expected.txt:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/import/animate-pservers-grad-01-b-manual-expected.txt:
* LayoutTests/platform/ios/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt:
* LayoutTests/platform/ios/svg/W3C-SVG-1.1/animate-elem-85-t-expected.txt:
* LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/import/animate-elem-30-t-manual-expected.txt:
* LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/import/animate-elem-85-t-manual-expected.txt:
* LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/import/animate-pservers-grad-01-b-manual-expected.txt:
* LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt:
* LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-85-t-expected.txt:
* LayoutTests/platform/wpe/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt:
* LayoutTests/platform/wpe/svg/W3C-SVG-1.1/animate-elem-85-t-expected.txt:
* LayoutTests/svg/animations/animate-montion-invalid-attribute.svg:
* LayoutTests/svg/custom/global-constructors-expected.txt:
* LayoutTests/svg/custom/global-constructors.html:
* LayoutTests/svg/dom/svg2-inheritance-expected.txt:
* LayoutTests/svg/dom/svg2-inheritance.html:
* LayoutTests/platform/gtk/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt:
* LayoutTests/platform/gtk/svg/W3C-SVG-1.1/animate-elem-85-t-expected.txt: Added new expectation

Canonical link: https://commits.webkit.org/276683@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications

More information about the webkit-changes mailing list