[webkit-changes] [WebKit/WebKit] 4322c3: Stack check size can be zero if omg skips stack ch...

[Justin Michaud]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4322c3bd5293d6b328b3745ef628cf9c41ca9cdb
      https://github.com/WebKit/WebKit/commit/4322c3bd5293d6b328b3745ef628cf9c41ca9cdb
  Author: Justin Michaud <justin_michaud at apple.com>
  Date:   2024-03-26 (Tue, 26 Mar 2024)

  Changed paths:
    A JSTests/wasm/stress/omg-osr-stack-check-2.js
    A JSTests/wasm/stress/omg-osr-stack-check-2.wasm
    M Source/JavaScriptCore/wasm/WasmCallee.h
    M Source/JavaScriptCore/wasm/WasmOMGIRGenerator.cpp
    M Source/JavaScriptCore/wasm/WasmOperations.cpp
    M Source/JavaScriptCore/wasm/WasmSlowPaths.cpp

  Log Message:
  -----------
  Stack check size can be zero if omg skips stack checks.
https://bugs.webkit.org/show_bug.cgi?id=271011
rdar://124390384

Reviewed by Yusuke Suzuki.

For leaf functions that have really small stacks, this stack check can
be skipped and the ASSERT(stackCheckSize()) is wrong.

We change the assert to ensure that the stack check size is set, but
if it is not needed, we can skip the stack check.

* Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::parseAndCompileB3):
* Source/JavaScriptCore/wasm/WasmCallee.h:

Originally-landed-as: 272448.753 at safari-7618-branch (aef93328873d). rdar://124390384
Canonical link: https://commits.webkit.org/276682@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications