[webkit-changes] [WebKit/WebKit] 60a617: [IFC][Partial layout] Clear caches when damage poi...

Alan Baradlay noreply at github.com
Fri Mar 22 05:53:14 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 60a617255b57b0e36fe56486894be8049794f447
      https://github.com/WebKit/WebKit/commit/60a617255b57b0e36fe56486894be8049794f447
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-03-22 (Fri, 22 Mar 2024)

  Changed paths:
    A LayoutTests/fast/inline/partial-layout-on-first-line-crash-expected.txt
    A LayoutTests/fast/inline/partial-layout-on-first-line-crash.html
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp

  Log Message:
  -----------
  [IFC][Partial layout] Clear caches when damage points to the beginning of the content
https://bugs.webkit.org/show_bug.cgi?id=271427
<rdar://125184161>

Reviewed by Antti Koivisto.

1. Content (style) gets mutated
2. Damage points to the beginning of the inline content
3. Subsequent layout gets initiated
4. Partial layout gets converted to full
5. Line layout uses stale inline items

Let's clear caches when partial layout is converted to full to make sure we don't end up with stale inline items.

* LayoutTests/fast/inline/partial-layout-on-first-line-crash-expected.txt: Added.
* LayoutTests/fast/inline/partial-layout-on-first-line-crash.html: Added.
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::layout):

Canonical link: https://commits.webkit.org/276536@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list