[webkit-changes] [WebKit/WebKit] 9ca509: [IFC][Partial layout] Unbalanced InlineBoxStart/En...

Alan Baradlay noreply at github.com
Fri Mar 22 05:44:48 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9ca509f5dfccbc06024ad94d1d2aefc9ed5e3eea
      https://github.com/WebKit/WebKit/commit/9ca509f5dfccbc06024ad94d1d2aefc9ed5e3eea
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-03-22 (Fri, 22 Mar 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    A LayoutTests/fast/text/bidi-text-and-partial-layout-crash-expected.txt
    A LayoutTests/fast/text/bidi-text-and-partial-layout-crash.html
    M Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp

  Log Message:
  -----------
  [IFC][Partial layout] Unbalanced InlineBoxStart/End may cause unexpected state in InlineItemsBuilder
https://bugs.webkit.org/show_bug.cgi?id=271430
<rdar://125183454>

Reviewed by Antti Koivisto.

This change ensures graceful recovery when partial layout produces unbalanced InlineBoxStart/End pairs with more InlineBoxEnd items than InlineBoxStart ones.

* LayoutTests/TestExpectations:
* LayoutTests/fast/text/bidi-text-and-partial-layout-crash-expected.txt: Added.
* LayoutTests/fast/text/bidi-text-and-partial-layout-crash.html: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:
(WebCore::Layout::handleEnterExitBidiContext):
(WebCore::Layout::rewindBidiContextStack):

Canonical link: https://commits.webkit.org/276535@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list