[webkit-changes] [WebKit/WebKit] a55f23: [WebCodecs] sampleRate and numberOfChannels are re...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a55f2304f88ff328ebbad4128ab76ae5a7e8a9ef
      https://github.com/WebKit/WebKit/commit/a55f2304f88ff328ebbad4128ab76ae5a7e8a9ef
  Author: Philippe Normand <philn at igalia.com>
  Date:   2024-03-20 (Wed, 20 Mar 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any.worker-expected.txt
    M LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any-expected.txt
    M LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any.worker-expected.txt
    M Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.cpp
    M Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoderConfig.h
    M Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoderConfig.idl
    M Source/WebCore/platform/AudioEncoder.h
    M Source/WebCore/platform/audio/gstreamer/AudioEncoderGStreamer.cpp

  Log Message:
  -----------
  [WebCodecs] sampleRate and numberOfChannels are required and have to be non-zero in a valid AudioEncoderConfig
https://bugs.webkit.org/show_bug.cgi?id=271238

Reviewed by Youenn Fablet.

Mark the sampleRate and numberOfChannels fields as required. The isValidAudioDataInit() function
already checks they are non-zero.

* Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.cpp:
(WebCore::createAudioEncoderConfig):
(WebCore::WebCodecsAudioEncoder::createEncodedChunkMetadata):
* Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoderConfig.h:
* Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoderConfig.idl:
* Source/WebCore/platform/AudioEncoder.h:
* Source/WebCore/platform/audio/gstreamer/AudioEncoderGStreamer.cpp:
(WebCore::GStreamerInternalAudioEncoder::initialize):

Canonical link: https://commits.webkit.org/276413@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications