[webkit-changes] [WebKit/WebKit] da50e6: [GStreamer][WebRTC] webrtc/connection-state.html s...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: da50e63df7f3e6b3090496e1dd8b4221752cdeff
      https://github.com/WebKit/WebKit/commit/da50e63df7f3e6b3090496e1dd8b4221752cdeff
  Author: Philippe Normand <philn at igalia.com>
  Date:   2024-03-20 (Wed, 20 Mar 2024)

  Changed paths:
    M LayoutTests/platform/glib/TestExpectations
    M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp

  Log Message:
  -----------
  [GStreamer][WebRTC] webrtc/connection-state.html started failing after update to 1.24.0
https://bugs.webkit.org/show_bug.cgi?id=271243
<rdar://problem/125014192>

Reviewed by Xabier Rodriguez-Calvar.

The `doneGatheringCandidates()` method is called by the PeerConnectionBackend when it's notified
from gst-webrtc that the ICE gathering is finished, so we don't need to call it ourselves. The
end-of-candidates SDP attribute shouldn't appear in the offer/answer the end-point reports either.
This is covered by the webrtc/libwebrtc/descriptionGetters.html test.

* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
(WebCore::fetchDescription):
(WebCore::GStreamerMediaEndpoint::doSetLocalDescription):
(WebCore::GStreamerMediaEndpoint::doSetRemoteDescription):
(WebCore::GStreamerMediaEndpoint::onIceCandidate):

Canonical link: https://commits.webkit.org/276412@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications