[webkit-changes] [WebKit/WebKit] 71b962: [WebGPU] only last getMappedRange() is copied back...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 71b962443b70953cb2b4840b22e76a99f5574759
      https://github.com/WebKit/WebKit/commit/71b962443b70953cb2b4840b22e76a99f5574759
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-03-19 (Tue, 19 Mar 2024)

  Changed paths:
    M Source/WebCore/Modules/WebGPU/GPUBuffer.cpp
    M Source/WebCore/Modules/WebGPU/GPUBuffer.h
    M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUBuffer.h

  Log Message:
  -----------
  [WebGPU] only last getMappedRange() is copied back to buffer in GPUMapMode.WRITE
https://bugs.webkit.org/show_bug.cgi?id=271261
<radar://125003533>

Reviewed by Dan Glastonbury.

We were only copying data from the most recent getMappedRange, which
is wrong, we need to copy from all the ranges.

* Source/WebCore/Modules/WebGPU/GPUBuffer.cpp:
(WebCore::GPUBuffer::~GPUBuffer):
(WebCore::makeArrayBuffer):
(WebCore::GPUBuffer::getMappedRange):
(WebCore::GPUBuffer::internalUnmap):
* Source/WebCore/Modules/WebGPU/GPUBuffer.h:

* Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUBuffer.h:
Change from void* to uint8_t* as this represents a byte vector.

Canonical link: https://commits.webkit.org/276382@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications