[webkit-changes] [WebKit/WebKit] ea1cc8: Update the PreviewWindowController to use PreviewItem

Etienne Segonzac noreply at github.com
Tue Mar 19 20:32:12 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ea1cc85f82ed82eae1be279bd597e9c49d995117
      https://github.com/WebKit/WebKit/commit/ea1cc85f82ed82eae1be279bd597e9c49d995117
  Author: Etienne Segonzac <sgz at apple.com>
  Date:   2024-03-19 (Tue, 19 Mar 2024)

  Changed paths:
    M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm
    M Source/WebKit/WebKitSwift/Preview/PreviewWindowController.swift
    M Source/WebKit/WebKitSwift/Preview/WKSPreviewWindowController.h

  Log Message:
  -----------
  Update the PreviewWindowController to use PreviewItem
https://bugs.webkit.org/show_bug.cgi?id=271291
<rdar://125040242>

Reviewed by Aditya Keerthi.

Update the PreviewWindowController to use PreviewItem. Since this is a
Swift type, WKSPreviewWindowController now takes a URL directly on init
and instantiates the PreviewItem internally.

* Source/WebKit/WebKitSwift/Preview/WKSPreviewWindowController.h:
New designated initializer.
* Source/WebKit/WebKitSwift/Preview/PreviewWindowController.swift:
(PreviewWindowController.item):
(PreviewWindowController.presentWindow):
Update to the PreviewItem variant of the`open` method.

* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(-[WKFullScreenWindowController _performSpatialFullScreenTransition:completionHandler:]):
Use the new WKSPreviewWindowController initializer.

Canonical link: https://commits.webkit.org/276381@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list