[webkit-changes] [WebKit/WebKit] 3b42a3: Remove legacy vertical inline box positioning

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3b42a329cb2a60cc5fa8681a3a70da08764761a9
      https://github.com/WebKit/WebKit/commit/3b42a329cb2a60cc5fa8681a3a70da08764761a9
  Author: Antti Koivisto <antti at apple.com>
  Date:   2024-03-14 (Thu, 14 Mar 2024)

  Changed paths:
    M Source/WebCore/rendering/LegacyInlineFlowBox.cpp
    M Source/WebCore/rendering/LegacyInlineFlowBox.h
    M Source/WebCore/rendering/LegacyLineLayout.cpp
    M Source/WebCore/rendering/LegacyLineLayout.h
    M Source/WebCore/rendering/LegacyRootInlineBox.cpp
    M Source/WebCore/rendering/LegacyRootInlineBox.h
    M Source/WebCore/rendering/RenderBlockFlow.cpp
    M Source/WebCore/rendering/RenderText.cpp
    R Source/WebCore/rendering/VerticalPositionCache.h
    M Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp

  Log Message:
  -----------
  Remove legacy vertical inline box positioning
https://bugs.webkit.org/show_bug.cgi?id=270984
rdar://problem/124626028

Reviewed by Alan Baradlay.

SVG is the last user of LegacyInlineBoxes but does its own inline layout and does not use this code.

* Source/WebCore/rendering/LegacyInlineFlowBox.cpp:
(WebCore::LegacyInlineFlowBox::requiresIdeographicBaseline const): Deleted.
(WebCore::verticalAlignApplies): Deleted.
(WebCore::LegacyInlineFlowBox::adjustMaxAscentAndDescent): Deleted.
(WebCore::LegacyInlineFlowBox::computeLogicalBoxHeights): Deleted.
(WebCore::placeChildInlineBoxesInBlockDirection): Deleted.
(WebCore::LegacyInlineFlowBox::placeBoxesInBlockDirection): Deleted.
(WebCore::LegacyInlineFlowBox::flipLinesInBlockDirection): Deleted.
* Source/WebCore/rendering/LegacyInlineFlowBox.h:
* Source/WebCore/rendering/LegacyLineLayout.cpp:
(WebCore::setLogicalWidthForTextRun):
(WebCore::LegacyLineLayout::computeInlineDirectionPositionsForLine):
(WebCore::LegacyLineLayout::computeInlineDirectionPositionsForSegment):
(WebCore::LegacyLineLayout::removeEmptyTextBoxesAndUpdateVisualReordering):
(WebCore::LegacyLineLayout::createLineBoxesFromBidiRuns):
(WebCore::LegacyLineLayout::layoutRunsAndFloatsInRange):
(WebCore::LegacyLineLayout::linkToEndLineIfNeeded):
(WebCore::LegacyLineLayout::computeBlockDirectionPositionsForLine): Deleted.
* Source/WebCore/rendering/LegacyLineLayout.h:
* Source/WebCore/rendering/LegacyRootInlineBox.cpp:
(WebCore::LegacyRootInlineBox::alignBoxesInBlockDirection): Deleted.
(WebCore::LegacyRootInlineBox::beforeAnnotationsAdjustment const): Deleted.
(WebCore::LegacyRootInlineBox::lineSnapAdjustment const): Deleted.
(WebCore::setAscentAndDescent): Deleted.
(WebCore::LegacyRootInlineBox::ascentAndDescentForBox const): Deleted.
(WebCore::LegacyRootInlineBox::verticalPositionForBox): Deleted.
(WebCore::LegacyRootInlineBox::includeLeadingForBox const): Deleted.
(WebCore::LegacyRootInlineBox::includeFontForBox const): Deleted.
(WebCore::LegacyRootInlineBox::includeGlyphsForBox const): Deleted.
(WebCore::LegacyRootInlineBox::includeInitialLetterForBox const): Deleted.
(WebCore::LegacyRootInlineBox::includeMarginForBox const): Deleted.
(WebCore::LegacyRootInlineBox::fitsToGlyphs const): Deleted.
(WebCore::LegacyRootInlineBox::includesRootLineBoxFontOrLeading const): Deleted.
* Source/WebCore/rendering/LegacyRootInlineBox.h:
(WebCore::LegacyRootInlineBox::hasAnnotationsBefore const): Deleted.
(WebCore::LegacyRootInlineBox::hasAnnotationsAfter const): Deleted.
* Source/WebCore/rendering/RenderBlockFlow.cpp:
* Source/WebCore/rendering/RenderText.cpp:
(WebCore::RenderText::positionLineBox): Deleted.
* Source/WebCore/rendering/VerticalPositionCache.h: Removed.
* Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::baselinePosition const):

Canonical link: https://commits.webkit.org/276115@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications