[webkit-changes] [WebKit/WebKit] 766540: Close database connection in SQLiteStorageArea on ...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 766540266e6cf950e62259d505a1de5e4833e451
      https://github.com/WebKit/WebKit/commit/766540266e6cf950e62259d505a1de5e4833e451
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2024-03-14 (Thu, 14 Mar 2024)

  Changed paths:
    M Source/WebKit/NetworkProcess/storage/SQLiteStorageArea.cpp
    M Source/WebKit/NetworkProcess/storage/SQLiteStorageArea.h

  Log Message:
  -----------
  Close database connection in SQLiteStorageArea on SQLITE_IOERR
https://bugs.webkit.org/show_bug.cgi?id=270940
rdar://123797002

Reviewed by Chris Dumez.

Database connection is dead after SQLITE_IOERR errors. SQLiteStorageArea should close and re-open database so it has a
chance to recover on such errors.

* Source/WebKit/NetworkProcess/storage/SQLiteStorageArea.cpp:
(WebKit::SQLiteStorageArea::isEmpty):
(WebKit::SQLiteStorageArea::prepareDatabase):
(WebKit::SQLiteStorageArea::getItemFromDatabase):
(WebKit::SQLiteStorageArea::allItems):
(WebKit::SQLiteStorageArea::setItem):
(WebKit::SQLiteStorageArea::removeItem):
(WebKit::SQLiteStorageArea::clear):
(WebKit::SQLiteStorageArea::handleDatabaseErrorIfNeeded):
(WebKit::SQLiteStorageArea::handleDatabaseCorruptionIfNeeded): Deleted.
* Source/WebKit/NetworkProcess/storage/SQLiteStorageArea.h:

Canonical link: https://commits.webkit.org/276114@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications