[webkit-changes] [WebKit/WebKit] 24260b: Add a quirk to store third-party cookies in partit...

Sihui noreply at github.com
Wed Mar 6 14:59:33 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 24260b1c915eded6dcd704ae8dd8dc05723c2d75
      https://github.com/WebKit/WebKit/commit/24260b1c915eded6dcd704ae8dd8dc05723c2d75
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
    M Source/WebCore/page/Quirks.cpp
    M Source/WebCore/page/Quirks.h
    M Source/WebKit/SourcesCocoa.txt
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    A Source/WebKit/WebProcess/WebPage/Cocoa/WebCookieJarCocoa.mm
    M Source/WebKit/WebProcess/WebPage/WebCookieJar.cpp
    M Source/WebKit/WebProcess/WebPage/WebCookieJar.h

  Log Message:
  -----------
  Add a quirk to store third-party cookies in partitioned storage
https://bugs.webkit.org/show_bug.cgi?id=270494
rdar://113830141

Reviewed by Chris Dumez.

cagreatamerica.com does not display correctly because an iframe from queue-it.net checks to cookie storage access from
script, and third-party cookies are fully blocked when ITP is enabled. To fix that, allow queue-it.net to read and write
cookies in partitioned storage. Note the storage is partitioned by top-level domain, so quirked domain cannot perform
cross-site tracking. Also the storage currently resides in the memory of web process, so the cookies are not applied to
network tasks.

* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::shouldUseEphemeralPartitionedStorageForDOMCookies const):
* Source/WebCore/page/Quirks.h:
* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/WebPage/Cocoa/WebCookieJarCocoa.mm: Added.
(WebKit::policyProperties):
(WebKit::WebCookieJar::cookiesInPartitionedCookieStorage const):
(WebKit::WebCookieJar::setCookiesInPartitionedCookieStorage):
(WebKit::WebCookieJar::ensurePartitionedCookieStorage):
* Source/WebKit/WebProcess/WebPage/WebCookieJar.cpp:
(WebKit::WebCookieJar::cookies const):
(WebKit::WebCookieJar::setCookies):
(WebKit::WebCookieJar::cookiesInPartitionedCookieStorage const):
(WebKit::WebCookieJar::setCookiesInPartitionedCookieStorage):
* Source/WebKit/WebProcess/WebPage/WebCookieJar.h:

Canonical link: https://commits.webkit.org/275763@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list