[webkit-changes] [WebKit/WebKit] 1c3f22: AX: AXPropertyName::{ColumnIndex, RowIndex} are no...

[Joshua Hoffman]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1c3f222f4f9644de8d8aa2a72aebaec90f45c03d
      https://github.com/WebKit/WebKit/commit/1c3f222f4f9644de8d8aa2a72aebaec90f45c03d
  Author: Joshua Hoffman <jhoffman23 at apple.com>
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
    A LayoutTests/accessibility/dynamic-table-row-column-indices-expected.txt
    A LayoutTests/accessibility/dynamic-table-row-column-indices.html
    A LayoutTests/accessibility/table-insert-second-thead-expected.txt
    A LayoutTests/accessibility/table-insert-second-thead.html
    M LayoutTests/platform/glib/TestExpectations
    M LayoutTests/platform/mac-wk1/TestExpectations
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/AXObjectCache.h
    M Source/WebCore/accessibility/AccessibilityTableColumn.cpp
    M Source/WebCore/accessibility/AccessibilityTableColumn.h
    M Source/WebCore/accessibility/AccessibilityTableRow.cpp
    M Source/WebCore/accessibility/AccessibilityTableRow.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp

  Log Message:
  -----------
  AX: AXPropertyName::{ColumnIndex, RowIndex} are not updated on the isolated tree
https://bugs.webkit.org/show_bug.cgi?id=270535
rdar://118240861

Reviewed by Tyler Wilcock.

These properties, ColumnIndex and RowIndex, were never updated on isolated objects
after being initialized. This can cause issues as ATs rely on these properties to
accurately navigate tables.

Two tests were added to flex this behavior. table-insert-second-thead.html also
tests that we are resilient to authoring errors with respect to multiple table
header elements.

* LayoutTests/accessibility/dynamic-table-row-column-indices-expected.txt: Added.
* LayoutTests/accessibility/dynamic-table-row-column-indices.html: Added.
* LayoutTests/accessibility/table-insert-second-thead-expected.txt: Added.
* LayoutTests/accessibility/table-insert-second-thead.html: Added.
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/mac-wk1/TestExpectations:
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::columnIndexChanged):
(WebCore::AXObjectCache::rowIndexChanged):
(WebCore::AXObjectCache::updateIsolatedTree):
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/accessibility/AccessibilityTableColumn.cpp:
(WebCore::AccessibilityTableColumn::setColumnIndex):
* Source/WebCore/accessibility/AccessibilityTableColumn.h:
* Source/WebCore/accessibility/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::setRowIndex):
* Source/WebCore/accessibility/AccessibilityTableRow.h:
(WebCore::AccessibilityTableRow::setRowIndex): Deleted.
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::updateNodeProperties):

Canonical link: https://commits.webkit.org/275762@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications