[webkit-changes] [WebKit/WebKit] 9600be: [WebGPU] After an invalid drawIndexed call, some v...

mwyrzykowski noreply at github.com
Wed Jun 5 12:04:07 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9600be358d0babb699b59988f17e59e10025ff4c
      https://github.com/WebKit/WebKit/commit/9600be358d0babb699b59988f17e59e10025ff4c
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-06-05 (Wed, 05 Jun 2024)

  Changed paths:
    A LayoutTests/fast/webgpu/regression/repro_275111-expected.txt
    A LayoutTests/fast/webgpu/regression/repro_275111.html
    A LayoutTests/fast/webgpu/regression/repro_275111b-expected.txt
    A LayoutTests/fast/webgpu/regression/repro_275111b.html
    M Source/WebGPU/WebGPU/Buffer.mm

  Log Message:
  -----------
  [WebGPU] After an invalid drawIndexed call, some valid draws can be discarded
https://bugs.webkit.org/show_bug.cgi?id=275111
<radar://129236340>

Reviewed by Dan Glastonbury.

Range check is wrong because a valid call within a previously invalid call
will be treated as a no-op, and alternatively the other way around.

* LayoutTests/fast/webgpu/regression/repro_275111-expected.txt: Added.
* LayoutTests/fast/webgpu/regression/repro_275111.html: Added.
* LayoutTests/fast/webgpu/regression/repro_275111b-expected.txt: Added.
* LayoutTests/fast/webgpu/regression/repro_275111b.html: Added.
Add regression test.

* Source/WebGPU/WebGPU/Buffer.mm:
(WebGPU::Buffer::indirectBufferRequiresRecomputation const):

Canonical link: https://commits.webkit.org/279750@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list