[webkit-changes] [WebKit/WebKit] c41cae: HeapIterationScope should require the JS API lock

[Keith Miller]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c41cae2236b0d5ab176b6aa835f5d6ed58ad193d
      https://github.com/WebKit/WebKit/commit/c41cae2236b0d5ab176b6aa835f5d6ed58ad193d
  Author: Keith Miller <keith_miller at apple.com>
  Date:   2024-06-05 (Wed, 05 Jun 2024)

  Changed paths:
    M Source/JavaScriptCore/heap/HeapIterationScope.h
    M Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp
    M Source/WebCore/page/PerformanceLogging.cpp

  Log Message:
  -----------
  HeapIterationScope should require the JS API lock
https://bugs.webkit.org/show_bug.cgi?id=275173
rdar://problem/129294904

Reviewed by Yusuke Suzuki.

Right now some users of HeapIterationScope aren't holding the JS API lock. This might
be ok but also runs the risk of some other thread running JS at the same time as heap
iteration. This patch changes all callers to hold the JS API lock.

* Source/JavaScriptCore/heap/HeapIterationScope.h:
(JSC::HeapIterationScope::HeapIterationScope):
* Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp:
(Inspector::InspectorDebuggerAgent::addSymbolicBreakpoint):
* Source/WebCore/page/PerformanceLogging.cpp:

Canonical link: https://commits.webkit.org/279749@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications