[webkit-changes] [WebKit/WebKit] 2a510c: Make sure IPCData correctly encodes / decodes a nu...

Chris Dumez noreply at github.com
Tue Jul 30 16:41:33 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2a510c1db4df61eb95f42fdc5e74f3fe1f447e99
      https://github.com/WebKit/WebKit/commit/2a510c1db4df61eb95f42fdc5e74f3fe1f447e99
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-07-30 (Tue, 30 Jul 2024)

  Changed paths:
    M Source/WTF/wtf/cf/VectorCF.h
    M Source/WebKit/Shared/Cocoa/CoreIPCData.h
    M Source/WebKit/Shared/Cocoa/CoreIPCData.serialization.in

  Log Message:
  -----------
  Make sure IPCData correctly encodes / decodes a null RetainPtr
https://bugs.webkit.org/show_bug.cgi?id=277369
rdar://132787264

Reviewed by Ryosuke Niwa.

We now serialize over IPC a `std::optional<std::span<const uint8_t>>` instead of
a `std::span<const uint8_t>`. This allows us to distinguish a null
`RetainPtr<CFDataRef>` and a pointer to a `CFDataRef` that is empty.

* Source/WTF/wtf/cf/VectorCF.h:
(WTF::toCFData):
* Source/WebKit/Shared/Cocoa/CoreIPCData.h:
(WebKit::CoreIPCData::CoreIPCData):
(WebKit::CoreIPCData::dataReference const):
* Source/WebKit/Shared/Cocoa/CoreIPCData.serialization.in:

Canonical link: https://commits.webkit.org/281615@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list