[webkit-changes] [WebKit/WebKit] a01578: WebCore::Timer should assert that web thread lock ...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a01578c7c53b262de50aa8dcc9923dfbe0185d15
      https://github.com/WebKit/WebKit/commit/a01578c7c53b262de50aa8dcc9923dfbe0185d15
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2024-07-30 (Tue, 30 Jul 2024)

  Changed paths:
    M Source/WebCore/platform/Timer.cpp

  Log Message:
  -----------
  WebCore::Timer should assert that web thread lock is held or the web thread is disabled
https://bugs.webkit.org/show_bug.cgi?id=277299

Reviewed by Wenson Hsieh.

Release assert WebThreadIsLockedOrDisabled in TimerBase::TimerBase and TimerBase::setNextFireTime.

Because WebCore::Timer always schedules timer in the web thread, it is incorrect to use this class
in the main thread of the UI process (which may or may not also use WebKitLegacy).

* Source/WebCore/platform/Timer.cpp:
(WebCore::TimerBase::TimerBase):
(WebCore::TimerBase::setNextFireTime):

Canonical link: https://commits.webkit.org/281614@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications