[webkit-changes] [WebKit/WebKit] 178111: Add extensions feature category and flag for exten...

Commit Queue noreply at github.com
Wed Jul 17 14:41:39 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 17811113e0171723d2f52ce0f53f3793e4225818
      https://github.com/WebKit/WebKit/commit/17811113e0171723d2f52ce0f53f3793e4225818
  Author: Ari Young <ari_young at apple.com>
  Date:   2024-07-17 (Wed, 17 Jul 2024)

  Changed paths:
    M Source/WTF/Scripts/GeneratePreferences.rb
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WTF/wtf/PlatformEnableCocoa.h
    M Source/WebKit/UIProcess/API/APIFeatureStatus.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKFeature.mm
    M Source/WebKit/UIProcess/API/glib/WebKitFeature.cpp
    M Source/WebKitLegacy/mac/WebView/WebFeature.h

  Log Message:
  -----------
  Add extensions feature category and flag for extension sidebar APIs

https://bugs.webkit.org/show_bug.cgi?id=276551
rdar://131476290

Reviewed by Brian Weinstein and Timothy Hatcher.

This PR adds a feature flag to control the enablement of the sidePanel
and sidebarAction WebExtension APIs. Additionally, this PR also adds a
compile-time switch to control the enablement of these APIs when
compiling. Finally, this PR also adds a category for "Extensions" to the
feature flag preferences.

* Source/WTF/Scripts/GeneratePreferences.rb: Add 'Extensions' category
  to list of valid feature flag preference categories.
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Add feature
  flag and defaults to web preferences (conditional on compile-time
  flag).
* Source/WTF/wtf/PlatformEnableCocoa.h: Add compile time flag
  ENABLE_WK_WEB_EXTENSIONS_SIDEBAR
* Source/WebKit/UIProcess/API/APIFeatureStatus.h: Add `Extensions` to
  `FeatureCategory` enum.
* Source/WebKit/UIProcess/API/Cocoa/_WKFeature.mm:
(-[_WKFeature category]): Add switch case to `category` property mapping
  `API::FeatureCategory::Extensions` to `WebFeatureCategoryExtensions`.
* Source/WebKit/UIProcess/API/glib/WebKitFeature.cpp:
(toFeatureCategory): Add switch case mapping
  `API::FeatureCategory::Extensions` to `"Extensions"`.
* Source/WebKitLegacy/mac/WebView/WebFeature.h: Add
  `WebFeatureCategoryExtensions` to `WebFeatureCategory` enum.

Canonical link: https://commits.webkit.org/281065@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list