[webkit-changes] [WebKit/WebKit] 383cc7: [Flex] RenderFlexibleBox:m_numberOfFlexItemsOnFirs...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 383cc71f2864cdc0c9fb5665ba4fa61f09cbf156
      https://github.com/WebKit/WebKit/commit/383cc71f2864cdc0c9fb5665ba4fa61f09cbf156
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-07-17 (Wed, 17 Jul 2024)

  Changed paths:
    M Source/WebCore/rendering/RenderFlexibleBox.cpp
    M Source/WebCore/rendering/RenderFlexibleBox.h

  Log Message:
  -----------
  [Flex] RenderFlexibleBox:m_numberOfFlexItemsOnFirstLine (*LastLine) should not be optional
https://bugs.webkit.org/show_bug.cgi?id=276698

Reviewed by Antti Koivisto.

No m_numberOfFlexItemsOnFirstLine value and *m_numberOfFlexItemsOnFirstLine == 0 practically mean the same thing.
...and instead of keep overriding m_numberOfFlexItemsOnLastLine in RenderFlexibleBox::layoutAndPlaceFlexItems, let's just set them when we finished processing all the flex items.

* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::firstLineBaseline const):
(WebCore::RenderFlexibleBox::lastLineBaseline const):
(WebCore::RenderFlexibleBox::baselineFlexItem const):
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::layoutAndPlaceFlexItems):
* Source/WebCore/rendering/RenderFlexibleBox.h:

Canonical link: https://commits.webkit.org/281050@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications