[webkit-changes] [WebKit/WebKit] 3ea407: [css-flexbox] SVGs as flex items (imported/w3c/web...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3ea4075db9b9ac865612712d6b7e5b6ceda6f5ce
      https://github.com/WebKit/WebKit/commit/3ea4075db9b9ac865612712d6b7e5b6ceda6f5ce
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-07-17 (Wed, 17 Jul 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/svg-intrinsic-size-001-expected.txt
    M Source/WebCore/rendering/RenderReplaced.cpp
    M Source/WebCore/rendering/RenderReplaced.h

  Log Message:
  -----------
  [css-flexbox] SVGs as flex items (imported/w3c/web-platform-tests/css/css-flexbox/svg-root-as-flex-item-002.html FAILS)
https://bugs.webkit.org/show_bug.cgi?id=221474
<rdar://problem/74279029>

Reviewed by Antti Koivisto.

https://www.w3.org/TR/css-sizing-3/#intrinsic-sizes
If replaced element (as flex or grid item) has preferred aspect ratio (and no intrinsic size) use the flex box's definite main size (in case of indefinite main size, we just fallback to 0px anyway).

1. Keep RenderReplaced::computeConstrainedLogicalWidth independent from preferred/actual computation so it only does what it says it does.
2. Callers decide whether they want computeConstrainedLogicalWidth or computeReplacedLogicalWidthRespectingMinMaxWidth.

* LayoutTests/TestExpectations:
* Source/WebCore/rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint):
* Source/WebCore/rendering/RenderReplaced.h:

Canonical link: https://commits.webkit.org/281049@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications