[webkit-changes] [WebKit/WebKit] c7d779: [UnifiedPDF] Add a WebKit2 logging channel for PDF

Abrar Rahman Protyasha noreply at github.com
Wed Jan 31 19:46:59 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c7d77992d7723987c30c5c614224f3c449a46586
      https://github.com/WebKit/WebKit/commit/c7d77992d7723987c30c5c614224f3c449a46586
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2024-01-31 (Wed, 31 Jan 2024)

  Changed paths:
    M Source/WebKit/Platform/Logging.h
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.mm
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  -----------
  [UnifiedPDF] Add a WebKit2 logging channel for PDF
https://bugs.webkit.org/show_bug.cgi?id=268485
rdar://122029724

Reviewed by Simon Fraser and Tim Horton.

Currently, we're logging some document layout information into the
Plugins channel, which is probably not the right space for this kind
of logging.

This patch introduces the `PDF` logging channel, which we can use for
all logging needs under WebKit/WebProcess/Plugins/PDF. We also converge
all our current logging calls, minus those for the incremental loader,
to adopt this channel.

* Source/WebKit/Platform/Logging.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::geometryDidChange):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.mm:
(WebKit::PDFDocumentLayout::updateLayout):
(WebKit::PDFDocumentLayout::layoutSingleColumn):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::pdfElementTypesForPluginPoint const):

Canonical link: https://commits.webkit.org/273883@main




More information about the webkit-changes mailing list