[webkit-changes] [WebKit/WebKit] 7ca356: [GTK] Check window focus with gtk_window_is_active()
Commit Queue
noreply at github.com
Wed Jan 31 19:44:55 PST 2024
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7ca356b2f1bfd368d4b5e9896efeb3072d24c793
https://github.com/WebKit/WebKit/commit/7ca356b2f1bfd368d4b5e9896efeb3072d24c793
Author: Georges Basile Stavracas Neto <feaneron at igalia.com>
Date: 2024-01-31 (Wed, 31 Jan 2024)
Changed paths:
M Source/WebKit/UIProcess/Gamepad/gtk/UIGamepadProviderGtk.cpp
Log Message:
-----------
[GTK] Check window focus with gtk_window_is_active()
https://bugs.webkit.org/show_bug.cgi?id=258264
Reviewed by Michael Catanzaro.
In GTK3, gtk_widget_has_focus() called on a GtkWindow has the semantics
of "does this window receive input". This semantic is not preserved in
GTK4; instead, gtk_window_is_active() is what yields the same results.
By using gtk_widget_has_focus() in UIGamepadProviderGtk, it always
returned false, and prevented gamepad detection from properly working.
Switch that to gtk_window_is_active().
* Source/WebKit/UIProcess/Gamepad/gtk/UIGamepadProviderGtk.cpp:
(WebKit::UIGamepadProvider::platformWebPageProxyForGamepadInput):
Canonical link: https://commits.webkit.org/273882@main
More information about the webkit-changes
mailing list