[webkit-changes] [WebKit/WebKit] acc1e8: [GStreamer][MediaStream] http/wpt/mediastream/medi...

Philippe Normand noreply at github.com
Tue Jan 30 06:08:13 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: acc1e85f3a1f6ad4efb765a3d720d5bc6ecd7a6b
      https://github.com/WebKit/WebKit/commit/acc1e85f3a1f6ad4efb765a3d720d5bc6ecd7a6b
  Author: Philippe Normand <philn at igalia.com>
  Date:   2024-01-30 (Tue, 30 Jan 2024)

  Changed paths:
    M LayoutTests/platform/glib/TestExpectations
    M LayoutTests/platform/wpe/TestExpectations
    M Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp
    M Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.cpp
    M Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.h

  Log Message:
  -----------
  [GStreamer][MediaStream] http/wpt/mediastream/mediastreamtrackprocessor-videoframe-timestamp.html fails
https://bugs.webkit.org/show_bug.cgi?id=268215

Reviewed by Xabier Rodriguez-Calvar.

The test was failing because the mediastreamsrc was attempting to register on incoming tracks before
they were ready. This issue was not obvious until now, usually we wait the PC track events and
associate the corresponding MediaStream with a media element. But this test is using a different
approach, relying on the RTCRtpReceiver API, without waiting on track events.

* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
(WebKitMediaStreamObserver::activeStatusChanged):
(webkitMediaStreamSrcCharacteristicsChanged):
* Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.cpp:
(WebCore::RealtimeIncomingSourceGStreamer::hasClient):
(WebCore::RealtimeIncomingSourceGStreamer::registerClient):
* Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.h:

Canonical link: https://commits.webkit.org/273743@main




More information about the webkit-changes mailing list