[webkit-changes] [WebKit/WebKit] e4117b: [web-animations] don't normalize progress for `vis...

Antoine Quint noreply at github.com
Tue Jan 30 05:33:41 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e4117be9080c9b337a0e9753bb66916a16002669
      https://github.com/WebKit/WebKit/commit/e4117be9080c9b337a0e9753bb66916a16002669
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2024-01-30 (Tue, 30 Jan 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-interpolation-expected.txt
    M Source/WebCore/animation/CSSPropertyAnimation.cpp

  Log Message:
  -----------
  [web-animations] don't normalize progress for `visibility` and `content-visibility` while animating
https://bugs.webkit.org/show_bug.cgi?id=268366

Reviewed by Tim Nguyen.

For CSS properties using a "discrete" animation type, we normalize the animated value to be either
0 or 1 depending on which side of the 0.5 progress value we stand. However, the `visibility` and
`content-visibility` properties have a special type of discrete animation support that requires
to not perform this value normalization, as will the `display` property when we add animation
support for it (see bug 267762).

We introduce a new wrapper type `NonNormalizedDiscretePropertyWrapper` to do just that and use
it for the two properties listed above. This addresses the last remaining failure for the
`content-visibility` interpolation test.

* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-interpolation-expected.txt:
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::AnimationPropertyWrapperBase::normalizesProgressForDiscreteInterpolation const):
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
(WebCore::blendStandardProperty):

Canonical link: https://commits.webkit.org/273742@main




More information about the webkit-changes mailing list