[webkit-changes] [WebKit/WebKit] 467895: Make CookieChangeObserver subclass CanMakeWeakPtr

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4678952452ad64be29a2c243fa2e5f42772bbdbf
      https://github.com/WebKit/WebKit/commit/4678952452ad64be29a2c243fa2e5f42772bbdbf
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2024-01-29 (Mon, 29 Jan 2024)

  Changed paths:
    M Source/WebCore/platform/network/NetworkStorageSession.h
    M Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm

  Log Message:
  -----------
  Make CookieChangeObserver subclass CanMakeWeakPtr
https://bugs.webkit.org/show_bug.cgi?id=268106
rdar://121623707

Reviewed by Chris Dumez.

We should not use CheckedPtr for class data members, i.e. NetworkStorageSession should store WeakPtr of
CookieChangeObserver instead of CheckedPtr.

* Source/WebCore/platform/network/NetworkStorageSession.h:
* Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm:
(WebCore::NetworkStorageSession::registerCookieChangeListenersIfNecessary):
(WebCore::NetworkStorageSession::startListeningForCookieChangeNotifications):
(WebCore::NetworkStorageSession::stopListeningForCookieChangeNotifications):

Canonical link: https://commits.webkit.org/273702@main