[webkit-changes] [WebKit/WebKit] df7782: Sync and update 'which' across KeyboardEvent, Mous...
Ahmad Saleem
noreply at github.com
Mon Jan 29 16:25:48 PST 2024
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: df7782c2b48baf7b7f2c5c23912ea4754232fc11
https://github.com/WebKit/WebKit/commit/df7782c2b48baf7b7f2c5c23912ea4754232fc11
Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
Date: 2024-01-29 (Mon, 29 Jan 2024)
Changed paths:
M Source/WebCore/dom/KeyboardEvent.cpp
M Source/WebCore/dom/KeyboardEvent.h
M Source/WebCore/dom/KeyboardEvent.idl
M Source/WebCore/dom/MouseEvent.cpp
M Source/WebCore/dom/MouseEvent.h
M Source/WebCore/dom/UIEvent.cpp
M Source/WebCore/dom/UIEvent.h
M Source/WebCore/dom/UIEvent.idl
Log Message:
-----------
Sync and update 'which' across KeyboardEvent, MouseEvent and UIEvent interfaces as per web specification
https://bugs.webkit.org/show_bug.cgi?id=253366
rdar://problem/106580687
Reviewed by Ryosuke Niwa.
This patch aligns WebKit with Gecko / Firefox, Blink / Chromium and Web Specifications [1], [2] and [3].
[1] https://w3c.github.io/uievents/#idl-uievent
[2] https://w3c.github.io/uievents/#idl-keyboardevent
[3] https://w3c.github.io/uievents/#idl-mouseevent
This patch modifies 'which' to be 'unsigned' as per web-specification and also remove it from 'KeyboardEvent'.
Merge: https://chromium.googlesource.com/chromium/src.git/+/cf13270c47f29b21ce7a8c937f598989cd66c840
* Source/WebCore/dom/KeyboardEvent.cpp:
(KeyboardEvent::which):
* Source/WebCore/dom/KeyboardEvent.h:
* Source/WebCore/dom/KeyboardEvent.idl:
* Source/WebCore/dom/MouseEvent.cpp:
(MouseEvent::which):
* Source/WebCore/dom/MouseEvent.h:
* Source/WebCore/dom/UIEvent.cpp:
(UIEvent::which):
* Source/WebCore/dom/UIEvent.h:
* Source/WebCore/dom/UIEvent.idl: Remove FIXME and align with web-spec
Canonical link: https://commits.webkit.org/273701@main
More information about the webkit-changes
mailing list