[webkit-changes] [WebKit/WebKit] 7ed567: ASSERT(m_parameters.options.mode == FetchOptions::...

youennf noreply at github.com
Sat Jan 27 14:23:14 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7ed567eb8e4de7d47283bda4b3ac6700650ab630
      https://github.com/WebKit/WebKit/commit/7ed567eb8e4de7d47283bda4b3ac6700650ab630
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2024-01-27 (Sat, 27 Jan 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm

  Log Message:
  -----------
  ASSERT(m_parameters.options.mode == FetchOptions::Mode::Navigate) loading a main frame PDF
https://bugs.webkit.org/show_bug.cgi?id=232535
rdar://85106013

Reviewed by Simon Fraser.

PDFPlugin::getResourceBytesAtPosition is triggering a load to a PDF resource previously done by a document loader.
This new load is using range requests, it should thus not be considered as a main resource request.
Given the original resource request is coming from a document loader, we need to explicitly set back the requester to unspecified.

* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm:
(WebKit::PDFPluginBase::startByteRangeRequest):

Canonical link: https://commits.webkit.org/273612@main




More information about the webkit-changes mailing list