[webkit-changes] [WebKit/WebKit] 4eb70e: Separate receivedPolicyDecision NavigationAction a...

Alex Christensen noreply at github.com
Sat Jan 27 11:43:01 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4eb70e7bd6abb075a7fff2eb658f7d03db8612cc
      https://github.com/WebKit/WebKit/commit/4eb70e7bd6abb075a7fff2eb658f7d03db8612cc
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-01-27 (Sat, 27 Jan 2024)

  Changed paths:
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/UIProcess/WebPageProxyInternals.h

  Log Message:
  -----------
  Separate receivedPolicyDecision NavigationAction and NavigationResponse code paths
https://bugs.webkit.org/show_bug.cgi?id=268191
rdar://121685561

Reviewed by Brady Eidson.

They are both times we ask the application if it wants to proceed, but they are different
flows with different parameters at different times in the loading process.  This begins
to untangle them.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::reload):
(WebKit::WebPageProxy::receivedNavigationActionPolicyDecision):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::receivedNavigationResponsePolicyDecision):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForResponseShared):
(WebKit::WebPageProxy::receivedNavigationPolicyDecision): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxyInternals.h:

Canonical link: https://commits.webkit.org/273611@main




More information about the webkit-changes mailing list