[webkit-changes] [WebKit/WebKit] a01156: [iOS] Time picker fails to dodge the software keyb...

Wenson Hsieh noreply at github.com
Wed Jan 24 23:35:58 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a011563227e99a7fb9f3d81a7ec7645d538b71ce
      https://github.com/WebKit/WebKit/commit/a011563227e99a7fb9f3d81a7ec7645d538b71ce
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2024-01-24 (Wed, 24 Jan 2024)

  Changed paths:
    M Source/WebKit/UIProcess/ios/forms/WKDatePickerPopoverController.mm

  Log Message:
  -----------
  [iOS] Time picker fails to dodge the software keyboard when presented below the element
https://bugs.webkit.org/show_bug.cgi?id=268056
rdar://120403319

Reviewed by Aditya Keerthi.

When presented *below* the time input, it's possible for time pickers to shrink (and sometimes even
dismiss) when a software keyboard is shown, upon focusing either the hour or minute field. Avoid
this for now by not presenting below the input; I've separately filed rdar://121571971 for UIKit to
investigate moving the popover content in this case, instead of shrinking to fit.

* Source/WebKit/UIProcess/ios/forms/WKDatePickerPopoverController.mm:
(-[WKDatePickerPopoverController presentInView:sourceRect:completion:]):

Canonical link: https://commits.webkit.org/273480@main




More information about the webkit-changes mailing list