[webkit-changes] [WebKit/WebKit] 16fc26: contentHint should be preserved when transferring ...

youennf noreply at github.com
Wed Jan 24 23:18:06 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 16fc264632e675343232c6aa6be92017f8c3757d
      https://github.com/WebKit/WebKit/commit/16fc264632e675343232c6aa6be92017f8c3757d
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2024-01-24 (Wed, 24 Jan 2024)

  Changed paths:
    M LayoutTests/http/wpt/mediastream/transfer-mediastreamtrack-to-worker-expected.txt
    M LayoutTests/http/wpt/mediastream/transfer-mediastreamtrack-to-worker.html
    M Source/WebCore/Headers.cmake
    M Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/platform/mediastream/MediaStreamTrackDataHolder.cpp
    M Source/WebCore/platform/mediastream/MediaStreamTrackDataHolder.h
    A Source/WebCore/platform/mediastream/MediaStreamTrackHintValue.h
    M Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp
    M Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h

  Log Message:
  -----------
  contentHint should be preserved when transferring a MediaStreamTrack
https://bugs.webkit.org/show_bug.cgi?id=267921
rdar://121516684

Reviewed by Eric Carlson.

We add contentHint as a slot in data holder.
We make sure to set contentHint in MediaStreamTrackPrivate constructor.
We remove the optimization in MediaStreamTrack::create for the document case since this creates two code paths that we would need to keep in sync.

* LayoutTests/http/wpt/mediastream/transfer-mediastreamtrack-to-worker-expected.txt:
* LayoutTests/http/wpt/mediastream/transfer-mediastreamtrack-to-worker.html:
* Source/WebCore/Headers.cmake:
* Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::contentHintToAtomString):
(WebCore::MediaStreamTrack::contentHint const):
(WebCore::MediaStreamTrack::setContentHint):
(WebCore::MediaStreamTrack::create):
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/mediastream/MediaStreamTrackDataHolder.cpp:
(WebCore::MediaStreamTrackDataHolder::MediaStreamTrackDataHolder):
* Source/WebCore/platform/mediastream/MediaStreamTrackDataHolder.h:
* Source/WebCore/platform/mediastream/MediaStreamTrackHintValue.h: Added.
* Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp:
(WebCore::MediaStreamTrackPrivate::MediaStreamTrackPrivate):
(WebCore::MediaStreamTrackPrivate::setContentHint):
(WebCore::MediaStreamTrackPrivate::toDataHolder):
* Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h:

Canonical link: https://commits.webkit.org/273479@main




More information about the webkit-changes mailing list