[webkit-changes] [WebKit/WebKit] 8e62e0: [WGSL] Failed constant conversion should clean the...
Tadeu Zagallo
noreply at github.com
Mon Jan 22 05:00:19 PST 2024
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8e62e079b8ab55343fa35e533d41505728711209
https://github.com/WebKit/WebKit/commit/8e62e079b8ab55343fa35e533d41505728711209
Author: Tadeu Zagallo <tzagallo at apple.com>
Date: 2024-01-22 (Mon, 22 Jan 2024)
Changed paths:
M Source/WebGPU/WGSL/TypeCheck.cpp
M Source/WebGPU/WGSL/tests/invalid/division.wgsl
M Source/WebGPU/WGSL/tests/invalid/modulo.wgsl
Log Message:
-----------
[WGSL] Failed constant conversion should clean the invalid constant
https://bugs.webkit.org/show_bug.cgi?id=267780
rdar://121247554
Reviewed by Mike Wyrzykowski.
If a constant is not valid in its target type, we should clean it so it's not further
used in subsequent checks.
* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visitVariable):
(WGSL::TypeChecker::visit):
(WGSL::TypeChecker::bitcast):
(WGSL::TypeChecker::chooseOverload):
(WGSL::TypeChecker::convertValue):
(WGSL::TypeChecker::convertValueImpl):
(WGSL::TypeChecker::setConstantValue):
* Source/WebGPU/WGSL/tests/invalid/division.wgsl:
* Source/WebGPU/WGSL/tests/invalid/modulo.wgsl:
Canonical link: https://commits.webkit.org/273296@main
More information about the webkit-changes
mailing list