[webkit-changes] [WebKit/WebKit] 9840b7: [WGSL] Array constructor should return when elemen...

Tadeu Zagallo noreply at github.com
Mon Jan 22 04:56:51 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9840b7e8fa258cd249f96660d66528aa3d31c6bf
      https://github.com/WebKit/WebKit/commit/9840b7e8fa258cd249f96660d66528aa3d31c6bf
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2024-01-22 (Mon, 22 Jan 2024)

  Changed paths:
    M Source/WebGPU/WGSL/TypeCheck.cpp
    M Source/WebGPU/WGSL/tests/invalid/array.wgsl

  Log Message:
  -----------
  [WGSL] Array constructor should return when element type is invalid
https://bugs.webkit.org/show_bug.cgi?id=267772
rdar://121247451

Reviewed by Mike Wyrzykowski.

When type checking array constructors (e.g. array<T, N>(...)) we failed to check if the
resolved element type (T in the previous example) was valid. If the type is resolved to
bottom, i.e. failed to resolve, the constructor should also fail.

* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visit):
* Source/WebGPU/WGSL/tests/invalid/array.wgsl:

Canonical link: https://commits.webkit.org/273295@main




More information about the webkit-changes mailing list