[webkit-changes] [WebKit/WebKit] f31c5c: First `make release` fails after deleting `WebKitB...

Elliott Williams noreply at github.com
Wed Jan 17 22:39:45 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f31c5c1ab031ab57f26e03d0c9a7d6d77fbd7366
      https://github.com/WebKit/WebKit/commit/f31c5c1ab031ab57f26e03d0c9a7d6d77fbd7366
  Author: Elliott Williams <emw at apple.com>
  Date:   2024-01-17 (Wed, 17 Jan 2024)

  Changed paths:
    M Makefile.shared

  Log Message:
  -----------
  First `make release` fails after deleting `WebKitBuild` directory
https://bugs.webkit.org/show_bug.cgi?id=267672
rdar://121164032

Unreviewed.

Follow up to "[webkitdirs] Compute Xcode destination specifier" in
273153 at main. It changed a backticks line in the Makefile to a $(shell )
directive, which was getting expanded before set-webkit-configuration
was called, leading to the Xcode options potentially referencing a stale
workspace.

Instead, go back to doing the expansion as a subshell with backticks,
but do it in a bash eval that builds an array. XcodeOptionString()
outputs whitespace-containing arguments with quotes, so eval-ing into an
array allows arguments like (-destination "generic/platform=iOS Simulator")
to be correctly passed to Xcode.

* Makefile.shared:

Canonical link: https://commits.webkit.org/273165@main




More information about the webkit-changes mailing list