[webkit-changes] [WebKit/WebKit] 3ed8ad: WebMResourceClientParent::loadFinished parameter i...

Jean-Yves Avenard noreply at github.com
Wed Jan 17 22:27:10 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3ed8adb00eb77e854ded172772b928e2d30ab534
      https://github.com/WebKit/WebKit/commit/3ed8adb00eb77e854ded172772b928e2d30ab534
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2024-01-17 (Wed, 17 Jan 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/WebMResourceClient.cpp
    M Source/WebCore/platform/graphics/WebMResourceClient.h
    M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.h
    M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm

  Log Message:
  -----------
  WebMResourceClientParent::loadFinished parameter is unused
https://bugs.webkit.org/show_bug.cgi?id=267669
rdar://121158587

Reviewed by Eric Carlson.

The parameter provided to WebMResourceClientParent::loadFinished is unused.
It could also potentially cause an issue if somehow loadFinished was incorrectly called
before dataReceived.

* Source/WebCore/platform/graphics/WebMResourceClient.cpp:
(WebCore::WebMResourceClient::loadFinished):
* Source/WebCore/platform/graphics/WebMResourceClient.h:
* Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.h:
* Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm:
(WebCore::MediaPlayerPrivateWebM::loadFinished):

Canonical link: https://commits.webkit.org/273164@main




More information about the webkit-changes mailing list