[webkit-changes] [WebKit/WebKit] 66b206: Remove WKBundleInspector object

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 66b20616e0792be022dd1265c9955b4b32a06929
      https://github.com/WebKit/WebKit/commit/66b20616e0792be022dd1265c9955b4b32a06929
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-01-12 (Fri, 12 Jan 2024)

  Changed paths:
    M Source/WebKit/Headers.cmake
    M Source/WebKit/Modules/OSX_Private.modulemap
    M Source/WebKit/Modules/iOS_Private.modulemap
    M Source/WebKit/Shared/API/APIObject.h
    M Source/WebKit/Shared/API/c/WKBase.h
    M Source/WebKit/Shared/API/c/wpe/WebKit.h
    M Source/WebKit/Sources.txt
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleAPICast.h
    R Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp
    R Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleInspector.h
    M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp
    M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.h
    M Source/WebKit/WebProcess/Inspector/WebInspector.cpp
    M Source/WebKit/WebProcess/Inspector/WebInspector.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp

  Log Message:
  -----------
  Remove WKBundleInspector object
https://bugs.webkit.org/show_bug.cgi?id=267462
rdar://120915383

Reviewed by Ryosuke Niwa.

WebKit::WebInspector is both an API::Object and an IPC::Connection::Client,
which is preventing a change I want to make to IPC::Connection::Client.
It turns out WKBundleInspector is only used in WebKitTestRunner for 3 test-only
functions.  Make WKBundlePage SPI for these functions instead.

* Source/WebKit/Modules/OSX_Private.modulemap:
* Source/WebKit/Modules/iOS_Private.modulemap:
* Source/WebKit/Shared/API/APIObject.h:
* Source/WebKit/Shared/API/c/WKBase.h:
* Source/WebKit/Sources.txt:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
* Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp: Removed.
* Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleInspector.h: Removed.
* Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageShowInspectorForTest):
(WKBundlePageCloseInspectorForTest):
(WKBundlePageEvaluateScriptInInspectorForTest):
(WKBundlePageGetInspector): Deleted.
* Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* Source/WebKit/WebProcess/Inspector/WebInspector.cpp:
(WebKit::WebInspector::create):
(WebKit::WebInspector::WebInspector):
* Source/WebKit/WebProcess/Inspector/WebInspector.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::inspector):
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::showWebInspector):
(WTR::TestRunner::closeWebInspector):
(WTR::TestRunner::evaluateInWebInspector):

Canonical link: https://commits.webkit.org/272995@main