[webkit-changes] [WebKit/WebKit] 6e586d: Reduce use of PolicyDecisionSender

Alex Christensen noreply at github.com
Fri Jan 12 15:10:16 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6e586d49182769f95c5cb61eef360cc99cc6b00a
      https://github.com/WebKit/WebKit/commit/6e586d49182769f95c5cb61eef360cc99cc6b00a
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-01-12 (Fri, 12 Jan 2024)

  Changed paths:
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h

  Log Message:
  -----------
  Reduce use of PolicyDecisionSender
https://bugs.webkit.org/show_bug.cgi?id=267467
rdar://120917694

Reviewed by Chris Dumez.

It is only needed for WebPageProxy::decidePolicyForNavigationActionSyncShared
to send a policy decision immediately if the client didn't respond immediately.
The rest of the use can be replaced by CompletionHandler.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::receivedNavigationPolicyDecision):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::decidePolicyForNavigationActionAsyncShared):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNavigationActionSyncShared):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForResponseShared):
(WebKit::WebPageProxy::PolicyDecisionSender::create): Deleted.
(WebKit::WebPageProxy::PolicyDecisionSender::send): Deleted.
(WebKit::WebPageProxy::PolicyDecisionSender::PolicyDecisionSender): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.h:

Canonical link: https://commits.webkit.org/272994@main




More information about the webkit-changes mailing list