[webkit-changes] [WebKit/WebKit] 256b84: Crash in ViewTransition::create

Alex Christensen noreply at github.com
Thu Jan 11 21:48:49 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 256b84642a016a230bdd4aa56ec2a26008301002
      https://github.com/WebKit/WebKit/commit/256b84642a016a230bdd4aa56ec2a26008301002
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-01-11 (Thu, 11 Jan 2024)

  Changed paths:
    A LayoutTests/fast/dom/view-transition-without-global-object-expected.txt
    A LayoutTests/fast/dom/view-transition-without-global-object.html
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/dom/Document.h

  Log Message:
  -----------
  Crash in ViewTransition::create
https://bugs.webkit.org/show_bug.cgi?id=265806
rdar://119142736

Reviewed by Tim Nguyen.

If there is no global object, return null.  This matches the behavior of Chromium.

* LayoutTests/fast/dom/view-transition-without-global-object-expected.txt: Added.
* LayoutTests/fast/dom/view-transition-without-global-object.html: Added.
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::startViewTransition):
* Source/WebCore/dom/Document.h:

Canonical link: https://commits.webkit.org/272959@main




More information about the webkit-changes mailing list