[webkit-changes] [WebKit/WebKit] 0c3392: AX: ASSERTION FAILED: m_table inside of AXIsolated...

Joshua Hoffman noreply at github.com
Thu Jan 11 21:45:31 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0c339289de3709d9364926b0480ceb11875478a6
      https://github.com/WebKit/WebKit/commit/0c339289de3709d9364926b0480ceb11875478a6
  Author: Joshua Hoffman <jhoffman23 at apple.com>
  Date:   2024-01-11 (Thu, 11 Jan 2024)

  Changed paths:
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp

  Log Message:
  -----------
  AX: ASSERTION FAILED: m_table inside of AXIsolatedTree::create
https://bugs.webkit.org/show_bug.cgi?id=267348
rdar://120788145

Reviewed by Andres Gonzalez.

We cannot rely on using axObjectCache.relations() to iterate the new relations during the creation of the
isolated tree, as that HashMap may be modified or in the process of being updated. This patch creates a
copy of these relations instead, to prevent this issue.

This change also prevents the need to call AXObjectCache::relations() twice—which could subsequently call
updateRelationsIfNeeded() downstream.

* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::create):

Canonical link: https://commits.webkit.org/272958@main




More information about the webkit-changes mailing list