[webkit-changes] [WebKit/WebKit] c6d8b9: REGRESSION (272706 at main): TestWebKitAPI.PDF.PrintS...

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c6d8b99f59c25be18018634dc25fff0d66022287
      https://github.com/WebKit/WebKit/commit/c6d8b99f59c25be18018634dc25fff0d66022287
  Author: Tim Horton <thorton at apple.com>
  Date:   2024-01-11 (Thu, 11 Jan 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/PDFScriptEvaluator.mm

  Log Message:
  -----------
  REGRESSION (272706 at main): TestWebKitAPI.PDF.PrintSize is failing on Intel
https://bugs.webkit.org/show_bug.cgi?id=267403
rdar://120837366

Reviewed by Richard Robinson, Megan Gardner and Aditya Keerthi.

* Source/WebKit/WebProcess/Plugins/PDF/PDFScriptEvaluator.mm:
(WebKit::appendValuesInPDFNameSubtreeToVector):
(WebKit::getAllScriptsInPDFDocument):
No matter how much we might want to use RetainPtr everywhere, some types just
aren't refcounted. Despite looking a lot like a refcounted CF type, CGPDFObjectRef
is one such type. Thus, it's best to not try to call -retain on it, or you
might crash. Or, humorously, if you're on arm64, not crash, but you've still
made a mistake.

Un-do this overuse of RetainPtr.

Canonical link: https://commits.webkit.org/272930@main