[webkit-changes] [WebKit/WebKit] 6250fe: LayoutState is only available during layout.

Alan Baradlay noreply at github.com
Thu Jan 11 11:21:02 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6250fe9ecef455e2e31995ffd5521f27e97521bb
      https://github.com/WebKit/WebKit/commit/6250fe9ecef455e2e31995ffd5521f27e97521bb
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-01-11 (Thu, 11 Jan 2024)

  Changed paths:
    A LayoutTests/fast/dynamic/marquee-with-grid-and-vertical-child-crash-expected.txt
    A LayoutTests/fast/dynamic/marquee-with-grid-and-vertical-child-crash.html
    M Source/WebCore/rendering/RenderBlockFlow.cpp

  Log Message:
  -----------
  LayoutState is only available during layout.
https://bugs.webkit.org/show_bug.cgi?id=267147
<rdar://119618951>

Reviewed by Antti Koivisto.

Grid (erroneously) may call layout on orthogonal child outside of the regular layout phase (during preferred width computation).

* LayoutTests/fast/dynamic/marquee-with-grid-and-vertical-child-crash-expected.txt: Added.
* LayoutTests/fast/dynamic/marquee-with-grid-and-vertical-child-crash.html: Added.
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutBlock):

Canonical link: https://commits.webkit.org/272929@main




More information about the webkit-changes mailing list