[webkit-changes] [WebKit/WebKit] 60c4b2: Clean up PlayStation usage of Chrome / ChromeClient

Ross Kirsling noreply at github.com
Wed Jan 10 17:55:44 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 60c4b2f3354cabcb107d815b7d9408a0c7a1be79
      https://github.com/WebKit/WebKit/commit/60c4b2f3354cabcb107d815b7d9408a0c7a1be79
  Author: Ross Kirsling <ross.kirsling at sony.com>
  Date:   2024-01-10 (Wed, 10 Jan 2024)

  Changed paths:
    M Source/WebCore/PlatformPlayStation.cmake
    M Source/WebCore/loader/EmptyClients.h
    M Source/WebCore/page/Chrome.h
    M Source/WebCore/page/ChromeClient.h
    R Source/WebCore/page/playstation/ChromePlayStation.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h

  Log Message:
  -----------
  Clean up PlayStation usage of Chrome / ChromeClient
https://bugs.webkit.org/show_bug.cgi?id=267314

Reviewed by Fujii Hironori.

Following 272433 at main, ensure PlayStation's usage of WebCore's Chrome and ChromeClient classes is sufficiently aligned
with other ports (most namely, Windows). In particular:

- Remove ChromePlayStation, which serves no purpose
- For PS-specific methods in ChromeClient...
  - make declarations pure virtual
  - put empty definitions in EmptyClients
  - stub out real definitions in WebChromeClient (to be implemented in a further patch)

* Source/WebCore/PlatformPlayStation.cmake:
* Source/WebCore/loader/EmptyClients.h:
* Source/WebCore/page/Chrome.h:
* Source/WebCore/page/ChromeClient.h:
* Source/WebCore/page/playstation/ChromePlayStation.cpp: Removed.
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h:

Canonical link: https://commits.webkit.org/272874@main




More information about the webkit-changes mailing list