[webkit-changes] [WebKit/WebKit] 46042d: Implement FELighting applier for Neon
Said Abou-Hallawa
noreply at github.com
Wed Jan 10 17:52:56 PST 2024
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 46042d525754c1af516aa6b4595ec33d0edf7625
https://github.com/WebKit/WebKit/commit/46042d525754c1af516aa6b4595ec33d0edf7625
Author: Said Abou-Hallawa <said at apple.com>
Date: 2024-01-10 (Wed, 10 Jan 2024)
Changed paths:
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
R Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.cpp
R Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h
A Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNeonParallelApplier.cpp
A Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNeonParallelApplier.h
M Source/WebCore/platform/graphics/filters/FELighting.cpp
M Source/WebCore/platform/graphics/filters/software/FECompositeSoftwareArithmeticApplier.cpp
M Source/WebCore/platform/graphics/filters/software/FELightingSoftwareApplier.cpp
M Source/WebCore/platform/graphics/filters/software/FELightingSoftwareApplier.h
A Source/WebCore/platform/graphics/filters/software/FELightingSoftwareParallelApplier.cpp
A Source/WebCore/platform/graphics/filters/software/FELightingSoftwareParallelApplier.h
Log Message:
-----------
Implement FELighting applier for Neon
https://bugs.webkit.org/show_bug.cgi?id=267349
rdar://120791073
Reviewed by Simon Fraser.
Add a virtual method to FELightingSoftwareApplier named applyPlatformParallel() and
call it from its applyPlatform(). Add two new classes FELightingSoftwareParallelApplier
and FELightingNeonParallelApplier and make each one of them implement this method. Move
the existing code in FELightingNEON to the new class FELightingNeonParallelApplier.
Make FELightingSoftwareParallelApplier for all other platforms.
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h: Removed.
* Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNeonParallelApplier.cpp: Renamed from Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.cpp.
(WebCore::FELightingNeonParallelApplier::feLightingConstants):
(WebCore::FELightingNeonParallelApplier::getPowerCoefficients):
(WebCore::FELightingNeonParallelApplier::applyPlatformWorker):
(WebCore::FELightingNeonParallelApplier::applyPlatformParallel const):
* Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNeonParallelApplier.h: Added.
* Source/WebCore/platform/graphics/filters/FELighting.cpp:
(WebCore::FELighting::createSoftwareApplier const):
* Source/WebCore/platform/graphics/filters/software/FECompositeSoftwareArithmeticApplier.cpp:
* Source/WebCore/platform/graphics/filters/software/FELightingSoftwareApplier.cpp:
(WebCore::FELightingSoftwareApplier::applyPlatform const):
(WebCore::FELightingSoftwareApplier::applyPlatformGenericPaint): Deleted.
(WebCore::FELightingSoftwareApplier::applyPlatformGenericWorker): Deleted.
(WebCore::FELightingSoftwareApplier::applyPlatformGeneric): Deleted.
(WebCore::FELightingSoftwareApplier::applyPlatform): Deleted.
* Source/WebCore/platform/graphics/filters/software/FELightingSoftwareApplier.h:
* Source/WebCore/platform/graphics/filters/software/FELightingSoftwareParallelApplier.cpp: Added.
(WebCore::FELightingSoftwareParallelApplier::applyPlatformPaint):
(WebCore::FELightingSoftwareParallelApplier::applyPlatformWorker):
(WebCore::FELightingSoftwareParallelApplier::applyPlatformParallel const):
* Source/WebCore/platform/graphics/filters/software/FELightingSoftwareParallelApplier.h: Added.
Canonical link: https://commits.webkit.org/272873@main
More information about the webkit-changes
mailing list