[webkit-changes] [WebKit/WebKit] b5982f: Fix warnings found by compiling with -Wc99-designa...

Commit Queue noreply at github.com
Mon Jan 8 07:58:15 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b5982fde2d0abead10f14d4f0f142242c055be4a
      https://github.com/WebKit/WebKit/commit/b5982fde2d0abead10f14d4f0f142242c055be4a
  Author: David Kilzer <ddkilzer at apple.com>
  Date:   2024-01-08 (Mon, 08 Jan 2024)

  Changed paths:
    M Source/WebCore/Modules/WebGPU/Implementation/WebGPUDeviceImpl.cpp
    M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
    M Source/WebCore/platform/graphics/cocoa/AudioTrackPrivateWebM.cpp
    M Source/WebCore/platform/graphics/cocoa/VideoTrackPrivateWebM.cpp
    M Source/WebKit/Shared/mac/MediaFormatReader/MediaSampleCursor.h

  Log Message:
  -----------
  Fix warnings found by compiling with -Wc99-designator and -Wreorder-init-list
https://bugs.webkit.org/show_bug.cgi?id=267203
<rdar://120609492>

Reviewed by Mike Wyrzykowski.

Every fix below is related to using designated initializers, and
initializing member fields in the same order that they are defined.  In
two cases, a struct inherits from another struct, and the designated
initializer syntax can't be used to initialize members in the base
struct, so IGNORE_WARNINGS_BEGIN/END is used instead.

* Source/WebCore/Modules/WebGPU/Implementation/WebGPUDeviceImpl.cpp:
(WebCore::WebGPU::DeviceImpl::importExternalTexture):
(WebCore::WebGPU::DeviceImpl::createBindGroup):
* Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateLastPixelBuffer):
* Source/WebCore/platform/graphics/cocoa/AudioTrackPrivateWebM.cpp:
(WebCore::AudioTrackPrivateWebM::updateConfiguration):
- Use IGNORE_WARNINGS_BEGIN("c99-designator")/IGNORE_WARNINGS_END to
  suppress the -Wc99-designator warning.
* Source/WebCore/platform/graphics/cocoa/VideoTrackPrivateWebM.cpp:
(WebCore::VideoTrackPrivateWebM::updateConfiguration):
- Ditto.
* Source/WebKit/Shared/mac/MediaFormatReader/MediaSampleCursor.h:
(WebKit::MediaSampleCursor::wrapperClass):

Canonical link: https://commits.webkit.org/272764@main




More information about the webkit-changes mailing list