[webkit-changes] [WebKit/WebKit] 925bb4: [IFC][Geometry] Update final box geometry with log...

Alan Baradlay noreply at github.com
Mon Jan 8 07:53:02 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 925bb4e63d01846f51af1e49a55eef6e92095790
      https://github.com/WebKit/WebKit/commit/925bb4e63d01846f51af1e49a55eef6e92095790
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-01-08 (Mon, 08 Jan 2024)

  Changed paths:
    M LayoutTests/fast/ruby/overhang-vertical-expected.txt
    M LayoutTests/fast/ruby/overhang-vertical-mixed-expected.txt
    M LayoutTests/platform/mac/fast/ruby/ruby-run-break-expected.txt
    M LayoutTests/platform/mac/fast/ruby/ruby-runs-expected.txt
    M LayoutTests/platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt
    M Source/WebCore/layout/formattingContexts/inline/InlineContentAligner.cpp
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
    M Source/WebCore/layout/layouttree/LayoutGeometryRect.h

  Log Message:
  -----------
  [IFC][Geometry] Update final box geometry with logical coords (inline-box)
https://bugs.webkit.org/show_bug.cgi?id=267183

Reviewed by Antti Koivisto.

Let's keep BoxGeometry logical.
(temporarily we need to covert ruby base from logical to visual for annotation placement/sizing -FIXME)

* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::processNonBidiContent):
(WebCore::Layout::InlineDisplayContentBuilder::adjustVisualGeometryForDisplayBox):
(WebCore::Layout::InlineDisplayContentBuilder::processBidiContent):
(WebCore::Layout::InlineDisplayContentBuilder::setInlineBoxGeometry):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::toBorderBoxVisualTopLeft):
(WebCore::LayoutIntegration::LineLayout::enclosingBorderBoxRectFor const):

Canonical link: https://commits.webkit.org/272763@main




More information about the webkit-changes mailing list