[webkit-changes] [WebKit/WebKit] c15868: Rename UserAgentPartIds to UserAgentParts

Anne van Kesteren noreply at github.com
Sun Jan 7 00:25:12 PST 2024 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c15868c771c4a4622949700d53c70abce580564c
      https://github.com/WebKit/WebKit/commit/c15868c771c4a4622949700d53c70abce580564c
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2024-01-07 (Sun, 07 Jan 2024)

  Changed paths:
    M LayoutTests/editing/style/apply-style-atomic-expected.txt
    M LayoutTests/editing/style/apply-style-atomic-live-range-expected.txt
    M LayoutTests/fast/dom/HTMLMeterElement/meter-clone-expected.txt
    M LayoutTests/fast/dom/HTMLMeterElement/meter-clone.html
    M LayoutTests/fast/dom/HTMLMeterElement/meter-element-markup-expected.txt
    M LayoutTests/fast/dom/HTMLProgressElement/progress-clone-expected.txt
    M LayoutTests/fast/dom/HTMLProgressElement/progress-clone.html
    M LayoutTests/fast/dom/HTMLProgressElement/progress-element-markup-expected.txt
    M LayoutTests/fast/dom/nodesFromRect/resources/nodesFromRect.js
    M LayoutTests/fast/forms/caps-lock-indicator-width.html
    M LayoutTests/fast/forms/resources/common.js
    M LayoutTests/fast/forms/search-field-buttons-do-not-have-focus-rings-expected.html
    M LayoutTests/fast/forms/search-field-buttons-do-not-have-focus-rings.html
    M LayoutTests/fast/forms/validation-message-clone-expected.txt
    M LayoutTests/fast/forms/validation-message-clone.html
    M LayoutTests/fast/html/clone-range-expected.txt
    M LayoutTests/fast/html/clone-range.html
    M LayoutTests/fast/html/details-clone.html
    M LayoutTests/http/tests/media/hls/hls-webvtt-style-expected.txt
    M LayoutTests/http/tests/media/hls/hls-webvtt-style.html
    M LayoutTests/http/tests/media/track/track-webvtt-vertical-multi-line-expected.txt
    M LayoutTests/http/tests/media/track/track-webvtt-vertical-multi-line.html
    M LayoutTests/inspector/css/pseudo-element-matches.html
    M LayoutTests/media/modern-media-controls/media-controller/media-controller-single-container-expected.txt
    M LayoutTests/media/modern-media-controls/media-controller/media-controller-single-container.html
    M LayoutTests/media/modern-media-controls/media-controls/media-controls-display-above-captions-expected.txt
    M LayoutTests/media/modern-media-controls/media-controls/media-controls-display-above-captions.html
    M LayoutTests/media/modern-media-controls/text-tracks/text-tracks-height-no-controls.html
    M LayoutTests/media/modern-media-controls/text-tracks/text-tracks-height-with-controls.html
    M LayoutTests/media/track/track-cue-vertical-style.html
    M LayoutTests/media/track/track-in-band-layout.html
    M LayoutTests/media/track/track-user-stylesheet-override.html
    M LayoutTests/media/track/webvtt-region-position-expected.txt
    M LayoutTests/media/track/webvtt-region-position.html
    M LayoutTests/platform/ios/ios/plugin/youtube-flash-plugin-iframe-expected.txt
    M LayoutTests/platform/ios/ios/plugin/youtube-flash-plugin-iframe.html
    M LayoutTests/plugins/quicktime-plugin-replacement-expected.txt
    M LayoutTests/plugins/quicktime-plugin-replacement.html
    M LayoutTests/resources/dump-as-markup.js
    M LayoutTests/userscripts/insert-stylesheets-with-pseudo.html
    M Source/WebCore/CMakeLists.txt
    M Source/WebCore/DerivedSources-output.xcfilelist
    M Source/WebCore/DerivedSources.make
    M Source/WebCore/Headers.cmake
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/css/CSSPseudoSelectors.json
    M Source/WebCore/css/SelectorChecker.cpp
    M Source/WebCore/css/process-css-pseudo-selectors.py
    M Source/WebCore/dom/Element.cpp
    M Source/WebCore/dom/Element.h
    M Source/WebCore/dom/mac/ImageControlsMac.cpp
    M Source/WebCore/html/BaseDateAndTimeInputType.cpp
    M Source/WebCore/html/ColorInputType.cpp
    M Source/WebCore/html/FileInputType.cpp
    M Source/WebCore/html/HTMLAttributeNames.in
    M Source/WebCore/html/HTMLMeterElement.cpp
    M Source/WebCore/html/RangeInputType.cpp
    M Source/WebCore/html/SearchInputType.cpp
    M Source/WebCore/html/TextFieldInputType.cpp
    M Source/WebCore/html/ValidationMessage.cpp
    M Source/WebCore/html/shadow/DateTimeEditElement.cpp
    M Source/WebCore/html/shadow/DateTimeFieldElements.cpp
    M Source/WebCore/html/shadow/DetailsMarkerControl.cpp
    M Source/WebCore/html/shadow/MediaControlTextTrackContainerElement.cpp
    M Source/WebCore/html/shadow/ProgressShadowElement.cpp
    M Source/WebCore/html/shadow/SliderThumbElement.cpp
    M Source/WebCore/html/shadow/SpinButtonElement.cpp
    M Source/WebCore/html/shadow/SwitchThumbElement.cpp
    M Source/WebCore/html/shadow/SwitchTrackElement.cpp
    M Source/WebCore/html/shadow/TextControlInnerElements.cpp
    M Source/WebCore/html/track/TextTrackCue.cpp
    M Source/WebCore/html/track/VTTCue.cpp
    M Source/WebCore/html/track/VTTRegion.cpp
    M Source/WebCore/inspector/agents/InspectorDOMAgent.cpp
    M Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp
    M Source/WebCore/rendering/RenderTheme.cpp
    M Source/WebCore/style/ElementRuleCollector.cpp
    M Source/WebCore/style/RuleData.cpp
    M Source/WebCore/style/StyleAdjuster.cpp
    M Source/WebCore/style/StyleInvalidator.cpp
    M Source/WebCore/style/StyleResolver.cpp
    M Source/WebCore/style/StyleSharingResolver.cpp
    M Source/WebCore/testing/Internals.cpp
    M Source/WebCore/testing/Internals.h
    M Source/WebCore/testing/Internals.idl

  Log Message:
  -----------
  Rename UserAgentPartIds to UserAgentParts
https://bugs.webkit.org/show_bug.cgi?id=267177

Reviewed by Tim Nguyen.

This also renames:

- pseudoAttr to useragentpartAttr
- Element::pseudo() to Element::userAgentPart()
- Element::setPseudo() to Element::setUserAgentPart()
- Internals::userAgentPartId() to Internals::userAgentPart()
- Internals::setUserAgentPartId() to Internals::setUserAgentPart()

And adjusts various variables and static functions accordingly.

* LayoutTests/editing/style/apply-style-atomic-expected.txt:
* LayoutTests/editing/style/apply-style-atomic-live-range-expected.txt:
* LayoutTests/fast/dom/HTMLMeterElement/meter-clone-expected.txt:
* LayoutTests/fast/dom/HTMLMeterElement/meter-clone.html:
* LayoutTests/fast/dom/HTMLMeterElement/meter-element-markup-expected.txt:
* LayoutTests/fast/dom/HTMLProgressElement/progress-clone-expected.txt:
* LayoutTests/fast/dom/HTMLProgressElement/progress-clone.html:
* LayoutTests/fast/dom/HTMLProgressElement/progress-element-markup-expected.txt:
* LayoutTests/fast/dom/nodesFromRect/resources/nodesFromRect.js:
(checkShadowContent):
* LayoutTests/fast/forms/caps-lock-indicator-width.html:
* LayoutTests/fast/forms/resources/common.js:
(getElementByPseudoId):
* LayoutTests/fast/forms/search-field-buttons-do-not-have-focus-rings-expected.html:
* LayoutTests/fast/forms/search-field-buttons-do-not-have-focus-rings.html:
* LayoutTests/fast/forms/validation-message-clone-expected.txt:
* LayoutTests/fast/forms/validation-message-clone.html:
* LayoutTests/fast/html/clone-range-expected.txt:
* LayoutTests/fast/html/clone-range.html:
* LayoutTests/fast/html/details-clone.html:
* LayoutTests/http/tests/media/hls/hls-webvtt-style-expected.txt:
* LayoutTests/http/tests/media/hls/hls-webvtt-style.html:
* LayoutTests/http/tests/media/track/track-webvtt-vertical-multi-line-expected.txt:
* LayoutTests/http/tests/media/track/track-webvtt-vertical-multi-line.html:
* LayoutTests/inspector/css/pseudo-element-matches.html:
* LayoutTests/media/modern-media-controls/media-controller/media-controller-single-container-expected.txt:
* LayoutTests/media/modern-media-controls/media-controller/media-controller-single-container.html:
* LayoutTests/media/modern-media-controls/media-controls/media-controls-display-above-captions-expected.txt:
* LayoutTests/media/modern-media-controls/media-controls/media-controls-display-above-captions.html:
* LayoutTests/media/modern-media-controls/text-tracks/text-tracks-height-no-controls.html:
* LayoutTests/media/modern-media-controls/text-tracks/text-tracks-height-with-controls.html:
* LayoutTests/media/track/track-cue-vertical-style.html:
* LayoutTests/media/track/track-in-band-layout.html:
* LayoutTests/media/track/track-user-stylesheet-override.html:
* LayoutTests/media/track/webvtt-region-position-expected.txt:
* LayoutTests/media/track/webvtt-region-position.html:
* LayoutTests/platform/ios/ios/plugin/youtube-flash-plugin-iframe-expected.txt:
* LayoutTests/platform/ios/ios/plugin/youtube-flash-plugin-iframe.html:
* LayoutTests/plugins/quicktime-plugin-replacement-expected.txt:
* LayoutTests/plugins/quicktime-plugin-replacement.html:
* LayoutTests/resources/dump-as-markup.js:
(Markup._get):
* LayoutTests/userscripts/insert-stylesheets-with-pseudo.html:
* Source/WebCore/CMakeLists.txt:
* Source/WebCore/DerivedSources-output.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Headers.cmake:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/CSSPseudoSelectors.json:
* Source/WebCore/css/SelectorChecker.cpp:
(WebCore::SelectorChecker::matchRecursively const):
* Source/WebCore/css/process-css-pseudo-selectors.py:
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::attributeChanged):
(WebCore::Element::userAgentPart const):
(WebCore::Element::setUserAgentPart):
(WebCore::Element::pseudo const): Deleted.
(WebCore::Element::setPseudo): Deleted.
* Source/WebCore/dom/Element.h:
* Source/WebCore/dom/mac/ImageControlsMac.cpp:
(WebCore::ImageControlsMac::createImageControls):
* Source/WebCore/html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::createShadowSubtree):
* Source/WebCore/html/ColorInputType.cpp:
(WebCore::ColorInputType::createShadowSubtree):
* Source/WebCore/html/FileInputType.cpp:
(WebCore::FileInputType::createShadowSubtree):
* Source/WebCore/html/HTMLAttributeNames.in:
* Source/WebCore/html/HTMLMeterElement.cpp:
(WebCore::setValueClass):
(WebCore::HTMLMeterElement::didAddUserAgentShadowRoot):
* Source/WebCore/html/RangeInputType.cpp:
(WebCore::RangeInputType::createShadowSubtree):
* Source/WebCore/html/SearchInputType.cpp:
(WebCore::updateResultButtonPseudoType):
* Source/WebCore/html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::createDataListDropdownIndicator):
(WebCore::autoFillButtonTypeToAutoFillButtonPseudoClassName):
(WebCore::isAutoFillButtonTypeChanged):
(WebCore::TextFieldInputType::createContainer):
(WebCore::TextFieldInputType::createAutoFillButton):
(WebCore::TextFieldInputType::updateAutoFillButton):
* Source/WebCore/html/ValidationMessage.cpp:
(WebCore::ValidationMessage::buildBubbleTree):
* Source/WebCore/html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditBuilder::visitLiteral):
(WebCore::DateTimeEditElement::create):
(WebCore::DateTimeEditElement::layout):
* Source/WebCore/html/shadow/DateTimeFieldElements.cpp:
(WebCore::DateTimeDayFieldElement::create):
(WebCore::DateTimeHourFieldElement::create):
(WebCore::DateTimeMeridiemFieldElement::create):
(WebCore::DateTimeMillisecondFieldElement::create):
(WebCore::DateTimeMinuteFieldElement::create):
(WebCore::DateTimeMonthFieldElement::create):
(WebCore::DateTimeSecondFieldElement::create):
(WebCore::DateTimeSymbolicMonthFieldElement::create):
(WebCore::DateTimeYearFieldElement::create):
* Source/WebCore/html/shadow/DetailsMarkerControl.cpp:
(WebCore::DetailsMarkerControl::create):
* Source/WebCore/html/shadow/MediaControlTextTrackContainerElement.cpp:
(WebCore::MediaControlTextTrackContainerElement::create):
* Source/WebCore/html/shadow/ProgressShadowElement.cpp:
(WebCore::ProgressInnerElement::create):
(WebCore::ProgressBarElement::create):
(WebCore::ProgressValueElement::create):
* Source/WebCore/html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::create):
(WebCore::SliderContainerElement::create):
* Source/WebCore/html/shadow/SpinButtonElement.cpp:
(WebCore::SpinButtonElement::create):
* Source/WebCore/html/shadow/SwitchThumbElement.cpp:
(WebCore::SwitchThumbElement::create):
* Source/WebCore/html/shadow/SwitchTrackElement.cpp:
(WebCore::SwitchTrackElement::create):
* Source/WebCore/html/shadow/TextControlInnerElements.cpp:
(WebCore::TextControlPlaceholderElement::create):
(WebCore::SearchFieldCancelButtonElement::create):
* Source/WebCore/html/track/TextTrackCue.cpp:
(WebCore::TextTrackCueBox::initialize):
(WebCore::tagPseudoObjects):
(WebCore::removeUserAgentPartAttributes):
(WebCore::TextTrackCue::getCueAsHTML):
(WebCore::TextTrackCue::rebuildDisplayTree):
(WebCore::removePseudoAttributes): Deleted.
* Source/WebCore/html/track/VTTCue.cpp:
(WebCore::VTTCue::obtainCSSBoxes):
* Source/WebCore/html/track/VTTRegion.cpp:
(WebCore::VTTRegion::getDisplayTree):
(WebCore::VTTRegion::prepareRegionDisplayTree):
* Source/WebCore/inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::highlightSelector):
* Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::captionsStyleSheetOverride const):
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::autoAppearanceForElement const):
* Source/WebCore/style/ElementRuleCollector.cpp:
(WebCore::Style::ElementRuleCollector::matchPartPseudoElementRules):
(WebCore::Style::ElementRuleCollector::collectMatchingUserAgentPartRules):
* Source/WebCore/style/RuleData.cpp:
(WebCore::Style::determinePropertyAllowlist):
* Source/WebCore/style/StyleAdjuster.cpp:
(WebCore::Style::Adjuster::adjust const):
* Source/WebCore/style/StyleInvalidator.cpp:
(WebCore::Style::Invalidator::invalidateUserAgentParts):
* Source/WebCore/style/StyleResolver.cpp:
(WebCore::Style::elementTypeHasAppearanceFromUAStyle):
* Source/WebCore/style/StyleSharingResolver.cpp:
(WebCore::Style::SharingResolver::canShareStyleWithElement const):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::userAgentPart):
(WebCore::Internals::setUserAgentPart):
(WebCore::Internals::userAgentPartId): Deleted.
(WebCore::Internals::setUserAgentPartId): Deleted.
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:

Canonical link: https://commits.webkit.org/272743@main

More information about the webkit-changes mailing list